ged photon modifications for pp_on_AA_2018 era

[bi-ran]

this PR aims to improve ged photon reconstruction performance in heavy ion collisions with the following changes:

• set upper bound for supercluster phi widths
• set supercluster phi widths to 0.2

some slides on the performance can be found at [1] and [2].

@ttrk @mandrenguyen

[cmsbuild]

The code-checks are being triggered in jenkins.

[slava77]

where are the closing braces?

Was this code checked?
http://cms-sw.github.io/PRWorkflow

[bi-ran]

sorry, this was fixed and tested locally but the changes were not committed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[slava77]

@cmsbuild please test workflow 158.0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23520/5099

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28546/console Started: 2018/06/07 18:32

[cmsbuild]

A new Pull Request was created by @bi-ran for master.

It involves the following packages:

RecoEcal/EgammaClusterProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @rovere, @argiro, @lgray, @varuns23 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: dca2d4f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23520/28546/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c985c6b
950fd72
3bf8ede
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23520/28546/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23520/28546/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23520/28546/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23520/158.0_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2902639
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2902447
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[slava77]

+1

for #23520 dca2d4f

• changes are in line with the PR description (and the linked slides)
• jenkins tests pass [wf 158.0 runs]
• local test with 200 events with wf 158.0 shows roughly expected behavior (the number of good photons is small)
  • the impact of the CPU cost is negligible (particleFlowSuperClusterECAL is down from 7 to 5 ms /evt; the effects on other modules is even smaller)

Here are a few plots of EB and EE R9 and cluster size: more pure egamma-like (high R9) clusters are roughly preserved; the size of clusters is reduced. The effect is most visible in the EB.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1