New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explicit types from parameter overrides in DigiToRawDM_cff #23722
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23722/5377 |
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: Configuration/StandardSequences @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+operations purely technical change to the StandardSequences , the parameter content is unchanged, but there is no explicit override of type, thank you @makortel |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 ok to enter into 10_2_X, as it is a technical protection against possible errors, expected to have no impact on the physics output |
This PR is a follow-up to the issue with missing pileup in DTs in premixing from couple months ago (that was fixed in #23091). If the parameter overrides would not have had the explicit types, we would have caught the problem (inconsistent parameters) already with the PR that introduced the bug. To prevent similar incidents in the future, this PR removes all explicit right-hand-side types from
DigiToRawDM_cff.py
.Tested in 10_2_0_pre6, no changes expected.
@mdhildreth @kpedro88