New pixel RecHit infrastructure for FastSim (for Phases 0, 1, 2, and beyond) #23799
Conversation
…ge and Big-pixel clusters
…ge and Big-pixel clusters
|
The code-checks are being triggered in jenkins. |
|
The code-checks are being triggered in jenkins. |
|
@pmaksim1 the comparison plots you provided look reasonably consistent to me. But I'm not sure why the hit resolutions changed for Run 1. Can you clarify this? |
|
@kpedro88 right, the external is needed here.. |
|
The baseline uses the PIXELAV from 2011 (at the lastest, possibly even earlier). It's mostly educated guesses of mostly a brand-new detector. The new resolution files use the current PIXELAV model of the detector that corresponds to 2016 data taking; it has been tuned on 2016 data, and matches the radiation damage from the middle of 2016 data taking, different voltages, etc. (I can provide more details, but the Pixel Offline Software meetings in Indico probably contain dozens of talks regarding various tweaks to bring PIXELAV to model the data accurately.) |
|
The whole point of our approach to FastSim is exactly this: all the detailed pixel sensor modeling, radiation damage, second-order-effects, etc. etc. -- is left to PIXELAV. We then use a very large PIXELAV run to make the resolution histograms (parameterized appropriately), and then feed that into FastSim. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fastsim-approved
fully-signed
and removed
fastsim-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
Thanks!!!
…On Sat, Aug 11, 2018 at 4:42 PM cmsbuild ***@***.***> wrote:
Merged #23799 <#23799> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23799 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEppUSn-D-m4SX4e-bwcdUKK4Nz1jzjIks5uP0GhgaJpZM4VP5q5>
.
|
…or Phases 0, 1, 2, and beyond))
…or Phases 0, 1, 2, and beyond))
…or Phases 0, 1, 2, and beyond))
New pixel RecHit infrastructure for FastSim (for Phases 0, 1, 2, and beyond), backport of ##23799 for 94X
…or Phases 0, 1, 2, and beyond))
squashed #23799 (New pixel RecHit infrastructure for FastSim (for Phases 0, 1, 2, and beyond))) -- backport to 10_2_X
This is the missing piece of Angira's "new FastSim tracking" PR which has already been integrated into 10.2.0, providing the correct resolution files for Phase 1. (This is especially important for the forward, since the geometry of the Phase1 forward disks is very different than from Phase 0.) The effect can clearly be seen in this plot:
Namely that there was little effect in the barrel, but there is a large effect in the forward (high eta) especially for the track fake rate. For Phase 0, the new code is statistically identical to the old code.
The summary of changes to the code:
Note that the hit merging is still off. Its effects have not been studied well enough to turn it on at this time.