Extend the hit pattern class to include MTD hits #24419
Conversation
|
The code-checks are being triggered in jenkins. |
|
As a note: I'll rebase this ontop of #24285 when it gets merged, since the public -> private changes for MTD/BTL/ETL DetIds are there. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24419/6231 |
|
A new Pull Request was created by @lgray (Lindsey Gray) for master. It involves the following packages: DataFormats/ForwardDetId @perrotta, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test workflow 22434.0 |
|
The tests are being triggered in jenkins. |
|
There was an issue with git-cms-merge-topic you can see the log here: |
|
Someone please kick this when all the plumbing is working again. |
|
the console has an error @smuzaffar did something go bad with some recent git updates? |
|
no idea but I am looking in to it. |
|
this could be related to the changes here cms-sw/cms-git-tools#99 |
|
-1 Tested at: b185fb3 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build HeaderConsistency
I found an error when building: /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-08-30-1100/src/FWCore/MessageLogger/interface/ErrorObj.icc: In instantiation of 'edm::ErrorObj& edm::ErrorObj::opltlt(const T&) [with T = DetId]':
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-08-30-1100/src/FWCore/MessageLogger/interface/ErrorObj.icc:44:20: required from 'edm::ErrorObj& edm::operator<<(edm::ErrorObj&, const T&) [with T = DetId]'
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-08-30-1100/src/FWCore/MessageLogger/interface/MessageSender.h:47:32: required from 'edm::MessageSender& edm::MessageSender::operator<<(const T&) [with T = DetId]'
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-08-30-1100/src/FWCore/MessageLogger/interface/MessageLogger.h:184:51: required from 'edm::LogError& edm::LogError::operator<<(const T&) [with T = DetId]'
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-08-30-1100/src/RecoTracker/TkSeedGenerator/src/SeedFromProtoTrack.cc:75:133: required from here
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-08-30-1100/src/FWCore/MessageLogger/interface/ErrorObj.icc:28:8: error: ambiguous overload for 'operator<<' (operand types are 'std::ostringstream {aka std::__cxx11::basic_ostringstream}' and 'const DetId')
myOs << t;
~~~~~^~~~
In file included from /cvmfs/cms-ib.cern.ch/nweek-02539/slc6_amd64_gcc700/external/gcc/7.0.0-omkpbe2/include/c++/7.3.1/istream:39:0,
from /cvmfs/cms-ib.cern.ch/nweek-02539/slc6_amd64_gcc700/external/gcc/7.0.0-omkpbe2/include/c++/7.3.1/sstream:38,
from /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc700/cms/cmssw-patch/CMSSW_10_3_X_2018-08-30-1100/src/FWCore/Utilities/interface/Exception.h:36,
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
@fwyzard @Martin-Grunewald could you please sign? Thanks! |
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
please test workflow 22434.0 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Extends the reco::HitPattern class to understand timing detector hits.
HitPattern is now 12 bits instead of 11, appropriate iorule added to maintain compatibility.
As discussed with @VinInn and company.
@fabiocos @bendavid @casarsa