Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly allow ParameterSet and its internals to be moveable #24429

Merged
merged 2 commits into from Sep 6, 2018
Merged

Explicitly allow ParameterSet and its internals to be moveable #24429

merged 2 commits into from Sep 6, 2018

Conversation

Dr15Jones
Copy link
Contributor

The previous code did not allow the compiler to create the default move related functions.

@Dr15Jones
Fix compilation error in atomic_value_ptr
6e2e834 
The copy constructor for an std::atomic does not exist.
@Dr15Jones
Explicitly allow move semantics with ParameterSet
4bec48b 
ParameterSet and its internals now explicitly allow copy and move.
@Dr15Jones
Copy link
Contributor Author

@davidlange6 FYI

@cmsbuild cmsbuild added this to the CMSSW_10_3_X milestone Aug 31, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24429/6252

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/ParameterSet
FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30181/console Started: 2018/08/31 20:02

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1
Tested at: 4bec48b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24429/30181/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
edb9f98
b31d805
af20b1d
19ae827
111cd66
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24429/30181/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24429/30181/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24429/30181/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3143879
  • DQMHistoTests: Total failures: 78
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3143604
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar smuzaffar mentioned this pull request Sep 1, 2018
Merged
@kpedro88
Copy link
Contributor

kpedro88 commented Sep 1, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30203/console Started: 2018/09/02 00:19

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2018

+1
Tested at: 4bec48b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24429/30203/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24429/30203/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3143879
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3143681
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@Dr15Jones
Copy link
Contributor Author

@fabiocos @kpedro88 ping

@fabiocos
Copy link
Contributor

fabiocos commented Sep 6, 2018

+1

@cmsbuild cmsbuild merged commit 7ed3aa2 into cms-sw:master Sep 6, 2018
@Dr15Jones Dr15Jones deleted the moveableParameterSet branch September 19, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @kpedro88 @fabiocos