Pr103x L1T for HI - update centrality algo in CaloLayer2 demux #24752

rekovic · 2018-09-28T12:58:34Z

PR 10_3_X needed for HI.

L1T - Small update in centrality algo in CaloLayer2 demux.

rekovic · 2018-09-28T12:58:46Z

please test

rekovic · 2018-09-28T12:58:50Z

+1

cmsbuild · 2018-09-28T12:58:53Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-09-28T13:00:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24752/6696

cmsbuild · 2018-09-28T13:01:06Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30769/console Started: 2018/09/28 16:41

cmsbuild · 2018-09-28T13:01:08Z

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2018-09-28T16:57:22Z

-1

Tested at: 2577d9d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24752/30769/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Fri Sep 28 18:28:59 2018-date Fri Sep 28 18:27:35 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:28:59 2018-date Fri Sep 28 18:27:35 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:28:59 2018-date Fri Sep 28 18:27:35 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 18:29:08 2018-date Fri Sep 28 18:27:39 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:29:08 2018-date Fri Sep 28 18:27:39 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:29:08 2018-date Fri Sep 28 18:27:39 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full2015Data --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Fri Sep 28 18:28:58 2018-date Fri Sep 28 18:27:43 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:28:58 2018-date Fri Sep 28 18:27:43 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:28:58 2018-date Fri Sep 28 18:27:43 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 18:33:12 2018-date Fri Sep 28 18:29:16 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:33:12 2018-date Fri Sep 28 18:29:16 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:33:12 2018-date Fri Sep 28 18:29:16 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_2018v35 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_2018v35_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 18:36:29 2018-date Fri Sep 28 18:33:20 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_2018v35.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:36:29 2018-date Fri Sep 28 18:33:20 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:2018v35,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2018v35 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_2018v35_DATA.root --fileout file:RelVal_Raw_2018v35_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:36:29 2018-date Fri Sep 28 18:33:20 2018 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Fri Sep 28 18:36:32 2018-date Fri Sep 28 18:36:18 2018 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Fri Sep 28 18:37:55 2018-date Fri Sep 28 18:36:33 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:37:55 2018-date Fri Sep 28 18:36:33 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:37:55 2018-date Fri Sep 28 18:36:33 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Fri Sep 28 18:38:32 2018-date Fri Sep 28 18:36:34 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:38:32 2018-date Fri Sep 28 18:36:34 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:38:32 2018-date Fri Sep 28 18:36:34 2018 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Fri Sep 28 18:38:53 2018-date Fri Sep 28 18:37:56 2018 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02543/slc6_amd64_gcc700/cms/cmssw/CMSSW_10_3_X_2018-09-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Sep 28 18:38:53 2018-date Fri Sep 28 18:37:56 2018 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Fri Sep 28 18:38:53 2018-date Fri Sep 28 18:37:56 2018 s - exit: 21504

cmsbuild · 2018-09-28T16:57:24Z

Comparison job queued.

cmsbuild · 2018-09-28T19:04:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24752/30769/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3162160
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3161958
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

Martin-Grunewald · 2018-10-01T07:25:45Z

please test

fabiocos · 2018-10-04T15:21:58Z

@rekovic @bundocka it would be good to clarify this issue asap, for integration in 10_3_X before moving forwrad

fabiocos · 2018-10-08T12:10:25Z

please test

cmsbuild · 2018-10-08T12:10:42Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30921/console Started: 2018/10/08 14:11

cmsbuild · 2018-10-08T15:06:20Z

+1
Tested at: 2577d9d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24752/30921/summary.html

cmsbuild · 2018-10-08T15:06:25Z

Comparison job queued.

cmsbuild · 2018-10-08T17:09:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24752/30921/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3162979
DQMHistoTests: Total failures: 73
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3162709
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2018-10-08T18:41:32Z

unhold

in the latest test no change affecting taus. @rekovic I think that the L1T reproducibility should be reviewed during LS2 (if not earlier)

cmsbuild · 2018-10-08T18:41:53Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-10-08T18:42:10Z

+1

bundocka added 3 commits September 28, 2018 14:54

Update HI centrality saturation, update HI caloParams

5c26487

Update HI centrality classes

0083f55

Transparent change to equality for clarity

2577d9d

cmsbuild added this to the CMSSW_10_3_X milestone Sep 28, 2018

cmsbuild added code-checks-pending comparison-pending fully-signed l1-approved orp-pending tests-pending labels Sep 28, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 28, 2018

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2018

cmsbuild added tests-rejected and removed tests-started labels Sep 28, 2018

cmsbuild added comparison-available and removed comparison-pending labels Sep 28, 2018

cmsbuild removed comparison-available tests-rejected labels Oct 1, 2018

cmsbuild added hold pending-signatures and removed fully-signed labels Oct 4, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Oct 8, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 8, 2018

cmsbuild added tests-approved and removed tests-started labels Oct 8, 2018

rekovic mentioned this pull request Oct 8, 2018

Pr103x L1T update centrality, saturation fixes, EG eta restriction, jetphi ring subtraction #24826

Closed

cmsbuild added comparison-available and removed comparison-pending labels Oct 8, 2018

cmsbuild added fully-signed and removed hold pending-signatures labels Oct 8, 2018

cmsbuild added orp-approved and removed orp-pending labels Oct 8, 2018

cmsbuild merged commit 193794b into cms-sw:master Oct 8, 2018

fabiocos mentioned this pull request Oct 9, 2018

Pr103x L1T update centrality, saturation fixes, EG eta restriction, jetphi ring subtraction (rebased) #24837

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pr103x L1T for HI - update centrality algo in CaloLayer2 demux #24752

Pr103x L1T for HI - update centrality algo in CaloLayer2 demux #24752

rekovic commented Sep 28, 2018

rekovic commented Sep 28, 2018

rekovic commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 •

edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

Martin-Grunewald commented Oct 1, 2018

fabiocos commented Oct 4, 2018

fabiocos commented Oct 8, 2018

cmsbuild commented Oct 8, 2018 •

edited

cmsbuild commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

fabiocos commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

fabiocos commented Oct 8, 2018

Pr103x L1T for HI - update centrality algo in CaloLayer2 demux #24752

Pr103x L1T for HI - update centrality algo in CaloLayer2 demux #24752

Conversation

rekovic commented Sep 28, 2018

rekovic commented Sep 28, 2018

rekovic commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018 • edited

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

cmsbuild commented Sep 28, 2018

Martin-Grunewald commented Oct 1, 2018

fabiocos commented Oct 4, 2018

fabiocos commented Oct 8, 2018

cmsbuild commented Oct 8, 2018 • edited

cmsbuild commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

fabiocos commented Oct 8, 2018

cmsbuild commented Oct 8, 2018

fabiocos commented Oct 8, 2018

cmsbuild commented Sep 28, 2018 •

edited

cmsbuild commented Oct 8, 2018 •

edited