Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr103x L1T update centrality, saturation fixes, EG eta restriction, jetphi ring subtraction #24826

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Oct 8, 2018

10 3 X PR (contains more then #24752)

-Swap out chunky sandwich for jet phi ring subtraction
-Update eg eta restriction
-Update centrality classes
-Update centrality saturation handling

@rekovic
Copy link
Contributor Author

rekovic commented Oct 8, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30927/console Started: 2018/10/08 17:27

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/L1TCalorimeter
L1TriggerConfig/L1TConfigProducers

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

Comparison job queued.

@fabiocos
Copy link
Contributor

fabiocos commented Oct 8, 2018

@rekovic the merge of #24752 seems to have broken this PR, please rebase it

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24826/30927/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162979
  • DQMHistoTests: Total failures: 247
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162535
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@davidlange6
Copy link
Contributor

Your PR is unmergeable. Please have a look and possibly rebase it.

@rekovic
Copy link
Contributor Author

rekovic commented Oct 9, 2018

replaced by #24837

@rekovic rekovic closed this Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants