Implement an EDFilter to select events based on their bunch crossing number (master) #25018
Conversation
|
The code-checks are being triggered in jenkins. |
|
type new-feature |
|
@cmsbuild, please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25018/6993 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: FWCore/Modules @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| void | ||
| BunchCrossingFilter::fillDescriptions(ConfigurationDescriptions& descriptions) { | ||
| ParameterSetDescription desc; | ||
| desc.add<unsigned int>("bunches")->setComment("Accept an event if its bunch crossing is in the list."); |
There was a problem hiding this comment.
This is inconsistent with line 28 that gets std::vector<unsigned int>.
There was a problem hiding this comment.
Thanks for catching it.
|
Whats the difference to #25017 |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25018/6996 |
|
The code-checks are being triggered in jenkins. |
Implement a global EDFilter "BunchCrossingFilter" to select events based on their bunch crossing number (between 1 and 3564 inclusive). Include a test configuration based on 2018 data.
fwyzard
force-pushed
the
BunchCrossingFilter_104x
branch
from
e2c4085
to
18d72fb
Compare
|
The code-checks are being triggered in jenkins. |
|
@cmsbuild, please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25018/7912
|
|
The tests are being triggered in jenkins. |
|
Pull request #25018 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
Implement a global EDFilter
BunchCrossingFilterto select events based on their bunch crossing number (between 1 and 3564 inclusive).Include a test configuration based on 2018 data.