Implement an EDFilter to select events based on their bunch crossing number (10.2.x)

[fwyzard]

Implement a global EDFilter BunchCrossingFilter to select events based on their bunch crossing number (between 1 and 3564 inclusive).

[fwyzard]

backport #25018

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_10_2_X.

It involves the following packages:

FWCore/Modules

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Implement an EDFilter to select events based on their bunch crossing number (master) #25018

[fwyzard]

type new-feature

[fwyzard]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31296/console Started: 2018/10/26 16:57

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[Dr15Jones]

-1
I missed the inconsistency in the fillDescriptions which was caught by @makortel

[cmsbuild]

Pull request #25020 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

[fwyzard]

Updated following the comments on #25018 .

[fwyzard]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32505/console Started: 2019/01/09 22:40

[cmsbuild]

+1
Tested at: ae391b5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25020/32505/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25020/32505/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007400
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3007206
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1