Backport to 94X: MET EE noise mitigation in 2017 data #25035

eioannou · 2018-10-29T13:48:51Z

Backport of #24876

cmsbuild · 2018-10-29T13:49:15Z

A new Pull Request was created by @eioannou (Emilios Ioannou) for CMSSW_9_4_X.

It involves the following packages:

JetMETCorrections/Type1MET
PhysicsTools/PatUtils

@perrotta, @monttj, @cmsbuild, @fgolf, @slava77, @peruzzim can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Backported from MET EE noise mitigation in 2017 data #24876

perrotta · 2018-10-29T13:54:00Z

please test

cmsbuild · 2018-10-29T13:54:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31330/console Started: 2018/10/29 14:54

perrotta · 2018-10-29T14:00:15Z

PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py

            self.setParameter('reclusterJets',True)

        #ZD: puppi jet reclustering breaks the puppi jets
        #overwriting of jet reclustering parameter for puppi
        if self._parameters["Puppi"].value and not onMiniAOD:
            self.setParameter('reclusterJets',False)

-        #jet collection overloading for automatic jet reclustering or JEC application


This was not removed in #24876, or later in the master: please check and fix

Hi @perrotta I didn't understand exactly what is this problem. Could you please help me on this?. I didn't remove this line in 94X.

These lines are not there any more: therefore, someone did remove them.

It was done by this commit from @kpedro88 :
4c2621a#diff-496fcf98e9a0901abbe07acea8ebda40

The same commit on the master only removed one empty line:
cms-met@6503137#diff-496fcf98e9a0901abbe07acea8ebda40

Please find out together with Kevin what happened there, and provide a fix either in 94X or in the master (or both...)

These lines were removed deliberately, because this default value was not actually used (overridden later), and its presence was confusing. It should have been removed in the upstream PR also. Perhaps there was a mistake in the rebase.

This makes sense. Please provide a PR in the master with the same removal then, so that the backport will remain synchronized with it.

cmsbuild · 2018-10-29T16:13:42Z

+1
Tested at: 4ac9dfe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25035/31330/summary.html

cmsbuild · 2018-10-29T16:13:54Z

Comparison job queued.

cmsbuild · 2018-10-29T17:23:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25035/31330/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2721493
DQMHistoTests: Total failures: 108
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2721223
DQMHistoTests: Total skipped: 162
DQMHistoTests: Total Missing objects: 0

perrotta · 2018-11-05T13:39:42Z

@eioannou please inform here as soon as the PR with the missing piece in the master is finally submitted, so that we can proceed with this backport

eioannou · 2018-11-05T16:36:55Z

Hi @perrotta should I make a new PR in the master removing those lines?

perrotta · 2018-11-05T16:54:24Z

As I already told you, either do so, or don't remove those lines in the backport: the backported code must be the same as the one merged in the master. According to what written earlier in this thread, I imagine that you should remove those lines in the master, in accordance to what was the original plan for this PR Emilios Ioannou <notifications@github.com> ha scritto:

…

Hi @perrotta should I make a new PR in the master removing those lines? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #25035 (comment)

eioannou · 2018-11-05T21:18:02Z

Hi @perrotta, I have created a new PR #25129 for the master by removing the unnecessary lines in order to be consistent with this backport.

perrotta · 2018-11-09T09:15:15Z

+1

Faithful backport of MET EE noise mitigation in 2017 data #24876 and MET EE noise mitigation in 2017 data [remove unnecessary lines] #25129
A new filter is made available for users.
- If the parameters in PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py are kept at their default value the newly added filter is disabled, and therefore no effect can be propagated to the standard workflows (and no effect is seen in the results of the jenkins tests, in fact)
- As such the pull request can be merged without modifying the default behaviour, and it is therefore suitable for being backported

peruzzim · 2018-11-09T10:38:33Z

We need this ported to 10_2_X as well asap, @eioannou could you please open the PR already?

eioannou · 2018-11-09T14:21:04Z

@peruzzim the PR for 10_2_X is #25173

fabiocos · 2018-11-14T05:57:09Z

+1

fabiocos · 2018-11-14T05:57:22Z

merge

no change to default expected

eioannou and others added 23 commits July 16, 2018 02:30

remove bad pf candidates clustered to jets

26d3bd7

remove bad pf candidates clustered to jets

c604d1e

cleanup

ae39568

simplify

c7362ea

respect user choice in reclusterJets

07e2bd2

add fixEE2017 and fixEE2017Params to MET tool

9f73448

make separate good jet collection

5fc2735

modules for EE fix in MET tool

f5b8329

fix params

6b1c0ec

get task

cf01898

fix jet type

9ad24d6

avoid product confusion

543fe23

improve default settings

3041f9e

add to sequence

a3d2130

remove unnecessary default

4c2621a

use correct collection in updateJECs()

693de24

use vector of Ptr instead of PtrVector (multithreading issue)

905f5c8

add switch to disable MET significance computation

054ac90

actually veto the superbad candidates

c2cfbc7

Change of Pt cut from 75 to 50GeV

e26b6ca

change of Pt to 50GeV and lower case for initials

80e9ab6

change of Pt to 50GeV and lower case for initials

f1951e5

lower case for initials

4ac9dfe

cmsbuild added this to the CMSSW_9_4_X milestone Oct 29, 2018

cmsbuild added analysis-pending backport-ok comparison-pending orp-pending pending-signatures reconstruction-pending labels Oct 29, 2018

cmsbuild added the tests-pending label Oct 29, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2018

perrotta reviewed Oct 29, 2018

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Oct 29, 2018

cmsbuild added comparison-available and removed comparison-pending labels Oct 29, 2018

peruzzim mentioned this pull request Nov 8, 2018

Add PFMET with FixEE2017 recipe cms-nanoAOD/cmssw#230

Merged

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Nov 9, 2018

cmsbuild added orp-approved and removed orp-pending labels Nov 14, 2018

cmsbuild merged commit 35c6665 into cms-sw:CMSSW_9_4_X Nov 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport to 94X: MET EE noise mitigation in 2017 data #25035

Backport to 94X: MET EE noise mitigation in 2017 data #25035

eioannou commented Oct 29, 2018

cmsbuild commented Oct 29, 2018 •

edited

perrotta commented Oct 29, 2018

cmsbuild commented Oct 29, 2018 •

edited

perrotta Oct 29, 2018

eioannou Oct 29, 2018

perrotta Oct 29, 2018

kpedro88 Oct 29, 2018

perrotta Oct 29, 2018

cmsbuild commented Oct 29, 2018

cmsbuild commented Oct 29, 2018

cmsbuild commented Oct 29, 2018

perrotta commented Nov 5, 2018

eioannou commented Nov 5, 2018

perrotta commented Nov 5, 2018 via email

eioannou commented Nov 5, 2018

perrotta commented Nov 9, 2018

peruzzim commented Nov 9, 2018

eioannou commented Nov 9, 2018

fabiocos commented Nov 14, 2018

fabiocos commented Nov 14, 2018

Backport to 94X: MET EE noise mitigation in 2017 data #25035

Backport to 94X: MET EE noise mitigation in 2017 data #25035

Conversation

eioannou commented Oct 29, 2018

cmsbuild commented Oct 29, 2018 • edited

perrotta commented Oct 29, 2018

cmsbuild commented Oct 29, 2018 • edited

perrotta Oct 29, 2018

Choose a reason for hiding this comment

eioannou Oct 29, 2018

Choose a reason for hiding this comment

perrotta Oct 29, 2018

Choose a reason for hiding this comment

kpedro88 Oct 29, 2018

Choose a reason for hiding this comment

perrotta Oct 29, 2018

Choose a reason for hiding this comment

cmsbuild commented Oct 29, 2018

cmsbuild commented Oct 29, 2018

cmsbuild commented Oct 29, 2018

perrotta commented Nov 5, 2018

eioannou commented Nov 5, 2018

perrotta commented Nov 5, 2018 via email

eioannou commented Nov 5, 2018

perrotta commented Nov 9, 2018

peruzzim commented Nov 9, 2018

eioannou commented Nov 9, 2018

fabiocos commented Nov 14, 2018

fabiocos commented Nov 14, 2018

cmsbuild commented Oct 29, 2018 •

edited

cmsbuild commented Oct 29, 2018 •

edited