Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made EcalDataFrame::MAXSAMPLES constexpr #25054

Closed
wants to merge 1 commit into from
Closed

Made EcalDataFrame::MAXSAMPLES constexpr #25054

wants to merge 1 commit into from

Conversation

Dr15Jones
Copy link
Contributor

The clang compiler was having a link error because the static class variable EcalDataFrame::MAXSAMPLES did not have an address defined. Changing it to constexpr solves the problem.

@Dr15Jones
Made EcalDataFrame::MAXSAMPLES constexpr
ab99f96 
The clang compiler was having a link error because the static
class variable EcalDataFrame::MAXSAMPLES did not have an address
defined. Changing it to constexpr solves the problem.
@cmsbuild cmsbuild added this to the CMSSW_10_4_X milestone Oct 30, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25054/7046

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/EcalDigi

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@rovere, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31367/console Started: 2018/10/30 15:20

@Dr15Jones
Copy link
Contributor Author

@fabiocos @smuzaffar this should fix the linker problems in the clang IB builds.

@smuzaffar
Copy link
Contributor

@Dr15Jones , this is already done via #25047 :-)

@Dr15Jones
Copy link
Contributor Author

closed in favor of #25047

@Dr15Jones Dr15Jones closed this Oct 30, 2018
@smuzaffar
Copy link
Contributor

abort

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@Dr15Jones Dr15Jones deleted the fixEcalDataFrameClang branch May 26, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-pending orp-pending pending-signatures simulation-pending tests-pending
Projects
None yet
Milestone
CMSSW_10_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @smuzaffar