Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements to CSC local trigger emulator #25165

Merged
merged 28 commits into from
Nov 29, 2018
Merged

Various improvements to CSC local trigger emulator #25165

merged 28 commits into from
Nov 29, 2018

Commits on Oct 30, 2018

  1. Make all CSC processors and TMBs inherit from common baseboard

    Sven Dildick committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    62539a1 View commit details
    Browse the repository at this point in the history

  2. Enable upgrade processors

    Sven Dildick committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    440cd3f View commit details
    Browse the repository at this point in the history

  3. Fixed a bug in CSCBaseboard

    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    9a42f6a View commit details
    Browse the repository at this point in the history

  4. slightly changes the cross bx algorihtm in ME11 motherboard. 

    small changes to CSCTriggerPrimitivesReader
    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    747ade3 View commit details
    Browse the repository at this point in the history

  5. Add the case for ME2/1 TMB without GEMs

    Sven Dildick committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    75ffbe1 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2018

  1. add some debugging information in emulator

    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    22b2e20 View commit details
    Browse the repository at this point in the history

  2. 1. allow same wiregroup triggered twice with some dead time between 

    2. optimized the cancellation logic
3. optimized the ALCT search part
    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    de33840 View commit details
    Browse the repository at this point in the history

  3. move the localized dead time zone to pretrigger level

    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    368bb18 View commit details
    Browse the repository at this point in the history

  4. optimized logtrace in CSCTriggerPrimitivesBuilder 

    change the configuration for clctSLHC to make it consistent with the ones for data-taking
    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    9339bda View commit details
    Browse the repository at this point in the history

  5. AnodeLCTProcessor: fix a bug in ghost cancellation logic

    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    23022d6 View commit details
    Browse the repository at this point in the history

  6. fix a bugs in ALCT ghost cancellation logic and CLCT localized dead t… 

    …ime zone
    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    4b81469 View commit details
    Browse the repository at this point in the history

  7. fix bug in CSCTriggerPrimitivesReader.cc

    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    e05f723 View commit details
    Browse the repository at this point in the history

  8. 1. fixed the dead time issue in AnodeLCTProcessor 

    2. move the dead time of Cathodeprocessor from trigger level to pretrigger level
    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    97ac54a View commit details
    Browse the repository at this point in the history

  9. Update configs for Phase-2

    Sven Dildick committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    e61d057 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions by code-checks

    Sven Dildick committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    7d3ea02 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. Fix ClangBuild errors

    Sven Dildick committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    c406a1c View commit details
    Browse the repository at this point in the history

  2. Fix ClangBuild errors

    Sven Dildick committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    639e857 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2018

  1. Fix different TMB options

    Sven Dildick committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    1ce58b4 View commit details
    Browse the repository at this point in the history

  2. Fix ClangBuild errors

    Sven Dildick committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    5da7950 View commit details
    Browse the repository at this point in the history

  3. fixed the halfstrip range in ME1a for halfstrip to gem pad LUT

    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    d97d835 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2018

  1. 1. fixed a bug in CSCCathodeLCTProcessor to avoid logic bug in a loop 

    2. add minor correction in CSCTriggerPrimitivesReader
    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    b77d9fd View commit details
    Browse the repository at this point in the history

  2. remove comment-out code

    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    ec7ec66 View commit details
    Browse the repository at this point in the history

  3. update the comment about why CLCTs in bx0 or 1 usually could be dropp… 

    …e in readout
    @tahuang1991
    tahuang1991 authored and Sven Dildick committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    ce28408 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2018

  1. Fix ClangBuild warnings

    Sven Dildick committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    ac2848a View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2018

  1. Fix includes. Remove refs to very old TMB options. Indentation

    Sven Dildick committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    5a24207 View commit details
    Browse the repository at this point in the history

  2. Cleanup

    Sven Dildick committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    a829bb9 View commit details
    Browse the repository at this point in the history

  3. Modernize for loops

    Sven Dildick committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    aa53e5b View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2018

  1. Fix static warnings

    Sven Dildick committed Nov 23, 2018
    Configuration menu
    Copy the full SHA
    d4bc574 View commit details
    Browse the repository at this point in the history