Few refinements on top of Stuck-TBM simulation CondFormats payload writers and readers #25546
Conversation
…iters and readers: - Add possibility to write default (= empty FEDChannel payloads) to SiPixelFEDChannelContainerWriteFromASCII, add possiblity not to write empty payload in SiPixelFEDChannelContainerTestWriter - Rename SiPixelFEDChannelContainerTestWriter to SiPixelFEDChannelContainerFromQualityConverter - Add SiPixelBadFEDChannelSimulationSanityChecker to check consistency of SiPixelQualityProbabilities and SiPixelFEDChannelContainer payloads
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25546/7767
|
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CalibTracker/SiPixelESProducers @tocheng, @cmsbuild, @franzoni, @ggovi, @pohsun, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This PR adds few refinements left over in #25466
Main features:
PixelFEDChannelpayloads) toSiPixelFEDChannelContainerWriteFromASCII, add possiblity to skip outputing empty PixelFEDChannel payload inSiPixelFEDChannelContainerTestWriterSiPixelFEDChannelContainerTestWritertoSiPixelFEDChannelContainerFromQualityConverterfor claritySiPixelBadFEDChannelSimulationSanityCheckerto check consistency ofSiPixelQualityProbabilitiesandSiPixelFEDChannelContainerpayloadsSiPixelQualityProbabilitiesWriteFromASCIINo change is meant in any production workflow.