Fix clang warnings in RecoTracker/SiTrackerMRHTools

[makortel]

This PR fixes the following warning from clang

warning: expression with side effects will be evaluated despite being used as an operand to 'typeid' [-Wpotentially-evaluated-expression]

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25549/7774

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

RecoTracker/SiTrackerMRHTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32342/console Started: 2018/12/21 21:16

[cmsbuild]

+1
Tested at: 3c4370a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25549/32342/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25549/32342/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153499
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

It's hard to me to believe that the changes observed in the inner track index of reco muons observed in the HI wf 150 are due to this PR. (There are also supposed modifications in DQM for the same workflow, although by looking at the plots pointed out they are more questionable).

In any case, perhaps it's worth giving it another look: any idea on the possible origin?

[slava77]

@cmsbuild please test

just to check if the observed changes are repeatable

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32369/console Started: 2018/12/25 19:07

[cmsbuild]

+1
Tested at: 3c4370a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25549/32369/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25549/32369/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153500
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

Reco comparison results: 5 differences found in the comparisons

this looks repeatable

[slava77]

I created #25570 to track the resolution and/or more examples of the issue

[perrotta]

+1

• Changes are in line with the PR description
• They are just technical ones, and should not lead to any change in the reco outputs
• The differences reported in the HI workflow in the jenkins tests are also observed in other, unrelated, pull requests (see Fixed clang warnings in RecoParticleFlow/PFProducer #25567); therefore their origin cannot be ascribed to this PR
  • Issue random differences in wf 150.0 #25570 made by Slava keeps track of it

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

+1