Fixed clang warnings in RecoParticleFlow/PFProducer #25567
Conversation
The file combination.hpp was a failed proposed addition to boost from 2007. Changes made - switched to using notboost namespace since we should not have our own files which use the boost namespace in order to avoid future name collisions - removed functions not used by CMS. One of the removed functions was generating a clang warning and appeared to have a bug.
-Made into a edm::one::EDAnalyzer -Fixed incorrect beginJob method signature -Added override usage
Now just return the value directly from findBlocks(). This avoids an unnecessary allocation for a std::unique_ptr and allows the compiler to do return value optimizations.
-Use new PFBlockAlgo::findBlocks interface -Move printing o blocks from PFBlockAlgo to the module -Use a EDPutTokenT
The elements in bare_elements_ and elements_ were identical, exception elements_ held the pointer via a std::unique_ptr. The performance of a std::unique_ptr and a bare pointer are identical so bare_elements_ is not needed.
|
The code-checks are being triggered in jenkins. |
|
|
||
|
|
||
| private: | ||
| virtual void beginJob(const edm::EventSetup&) ; |
There was a problem hiding this comment.
This was the wrong function signature.
|
|
||
|
|
||
| private: | ||
| virtual void beginJob(const edm::EventSetup&) ; |
There was a problem hiding this comment.
This was the wrong function signature.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25567/7798 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoParticleFlow/PFProducer @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Fixed clang warnings in RecoParticleFlow/PFProducer
Fixed clang warnings in RecoParticleFlow/PFProducer
Also did some minor improvements to PFProducer and PFBlockAlgo.