Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ResidualDecay port from 62X #2565

Merged
merged 2 commits into from
Feb 23, 2014
Merged

Fix ResidualDecay port from 62X #2565

merged 2 commits into from
Feb 23, 2014

Conversation

mkirsano
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mkirsano for CMSSW_7_1_X.

Fix ResidualDecay port from 62X

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mkirsano
Copy link
Contributor Author

It was forgotten to be ported from 6_2_X (change made last year)

@cmsbuild
Copy link
Contributor

Pull request #2565 was updated. @vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2565/253/summary.html

@vciulli
Copy link
Contributor

vciulli commented Feb 23, 2014

+1

On 20 Feb 2014, at 22:17, cmsbuild notifications@github.com wrote:

Pull request #2565 was updated. @vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please check and sign again.

—
Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 23, 2014
@ktf
Merge pull request #2565 from mkirsano/fix_residualdecay71
a9a6f3b 
Generators updates -- Fix ResidualDecay port from 62X
@ktf ktf merged commit a9a6f3b into cms-sw:CMSSW_7_1_X Feb 23, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
bendavid pushed a commit to bendavid/cmssw that referenced this pull request Sep 28, 2014
@ktf @bendavid
Merge pull request cms-sw#2565 from mkirsano/fix_residualdecay71
103f31f 
Generators updates -- Fix ResidualDecay port from 62X
Conflicts:
	GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
@smuzaffar
Merge pull request cms-sw#2565 from iahmad-khan/81x530scipy180
6c58259 
upgrades py2-scipy to 0.18.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed generators-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_1_0_pre5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkirsano @cmsbuild @vciulli @ktf @nclopezo