Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added firstLuminosityBlockForEachRun to ProducerSourceBase #25752

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Added firstLuminosityBlockForEachRun to ProducerSourceBase #25752

merged 2 commits into from
Jan 30, 2019

Conversation

Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Jan 23, 2019 •
edited

Using firstLuminosityBlockForEachRun allows one to trigger a new Run with a specific Run number to be started if a LuminosityBlock of a certain LuminosityBlock number is generated.
This is intended to be used by the Run dependent MC.

@Dr15Jones
Added firstLuminosityBlockForEachRun to ProducerSourceBase
dc9c155 
Using firstLuminosityBlockForEachRun allows one to trigger a new Run which a specific Run number to be started if a LuminosityBlock of a certain LuminosityBlock number is generated.
This is intended to be used by the Run dependent MC.
@cmsbuild cmsbuild added this to the CMSSW_10_5_X milestone Jan 23, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25752/8154

  • This PR adds an extra 16KB to repository

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32801/console Started: 2019/01/23 22:45

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Modules
FWCore/Sources

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: dc9c155

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25752/32801/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestIntegrationProducedSource had ERRORS
---> test TestIntegrationExternalSource had ERRORS
---> test TestGeneratorInterfaceLHEInterfaceFileReading had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25752/32801/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@Dr15Jones
Added fillDescriptions to pick up new parameter default values
28de0c3 
Source inheriting from ProducerSourceBase needed to declare
fillDescriptions in order to get the new parameter set with
the default value.
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 24, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32826/console Started: 2019/01/24 16:45

@cmsbuild
Copy link
Contributor

Pull request #25752 was updated. @smuzaffar, @efeyazgan, @Dr15Jones, @perrozzi, @cmsbuild, @alberto-sanchez, @qliphy can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: 28de0c3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25752/32826/summary.html
Additional comment: 'Compilation

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25752/32826/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@Dr15Jones
Copy link
Contributor Author

+1

@Dr15Jones
Copy link
Contributor Author

ping

@alberto-sanchez
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

the compilation warnings were unrelated to this PR

@cmsbuild cmsbuild merged commit 42dcc88 into cms-sw:master Jan 30, 2019
@mmusich mmusich mentioned this pull request Jan 31, 2019
Merged
@Dr15Jones Dr15Jones deleted the emptySourceRunDependentMC branch February 4, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available core-approved fully-signed generators-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_5_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @alberto-sanchez @fabiocos