Make edm::EventSetup a facade #25783
Conversation
edm::EventSetup is now just a wrapper around the new edm::EventSetupImpl. The latter has all the functionality of the previous edm::EventSetup. This now matches the pattern used elsewhere, such as edm::Event and edm::EventPrincipal. This will allow additional upcoming changes.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25783/8214
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 73eb6b8 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build HeaderConsistency
I found compilation error when building: @@@@ Running edmWriteConfigs for testGeometryRPCRadii
--- Registered EDM Plugin: testGeometryRPCRadii
Entering library rule at src/Geometry/RPCGeometry/test
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_5_X_2019-01-29-1100/src/Geometry/RPCGeometry/test/RPCGEO2.cc
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_5_X_2019-01-29-1100/src/Geometry/RPCGeometry/test/RPCGEO2.cc: In member function 'virtual void RPCGEO2::analyze(const edm::Event&, const edm::EventSetup&)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_5_X_2019-01-29-1100/src/Geometry/RPCGeometry/test/RPCGEO2.cc:79:4: error: invalid use of incomplete type 'const class edm::EventSetup'
iSetup.get().get(rpcGeo);
^~~~~~
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_5_X_2019-01-29-1100/src/Geometry/RPCGeometry/test/RPCGEO2.cc:24:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_5_X_2019-01-29-1100/src/FWCore/Framework/interface/Frameworkfwd.h:23:9: note: forward declaration of 'class edm::EventSetup'
class EventSetup;
|
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
Too many other files in CMSSW are depending on this file containing the include of EventSetup.h in this file.
cmsbuild
added
code-checks-pending
comparison-pending
tests-pending
and removed
code-checks-approved
comparison-notrun
tests-rejected
labels
|
+1 |
|
+1 |
|
+1 |
| @@ -241,6 +241,7 @@ RPCSeedGenerator::produce(edm::Event& iEvent, const edm::EventSetup& iSetup) | |||
|
|
|||
| // Start from filling layers to filling seeds | |||
| LayerFinder.fill(); | |||
| Overlapper.setEventSetup(iSetup); | |||
There was a problem hiding this comment.
there is a call to setEventSetup in the beginRun.
Is it added here because iSetup can now change during a job (or an IOV)?
There was a problem hiding this comment.
The edm::EventSetup object is now a temporary that only lives for the life-time of the call. All the management of the IOVs and data is done by a new edm::EventSetupImpl object which is held by the edm::EventSetup and has a longer lifetime.
|
+1 |
|
dependent on #25838 must be merged after that |
|
+1 |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 the DQM differences appear unrelated to this PR, long standing non reproducibility of L1T code |
edm::EventSetup is now just a wrapper around the new edm::EventSetupImpl. The latter has all the functionality of the previous edm::EventSetup. This now matches the pattern used elsewhere, such as edm::Event and edm::EventPrincipal.
This will allow additional upcoming changes.