Remove EventSetup from PixelFitterBase-derived classes

[makortel]

Pass the EventSetup via run() arguments instead.

Tested in 10_5_0_pre1, no changes expected.

@Dr15Jones

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25838/8291

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FastSimulation/Tracking
RecoPixelVertexing/PixelLowPtUtilities
RecoPixelVertexing/PixelTrackFitting

@perrotta, @civanch, @lveldere, @ssekmen, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @matt-komm, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32965/console Started: 2019/02/01 23:18

[cmsbuild]

+1
Tested at: 77eafe9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25838/32965/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25838/32965/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[Dr15Jones]

This will be needed for #25783

[slava77]

This will be needed for #25783

IIUC, the #25783 passed the jenkins tests.
In which way is this PR needed for that one?
Please clarify what you mean.

[Dr15Jones]

IIUC, the #25783 passed the jenkins tests. In which way is this PR needed for that one?
Please clarify what you mean.

The edm::EventSetup object is now created on the stack just before calling the standard event methods, e.g. produce, of a module. So passing a pointer to the edm::EventSetup from one module to another module is not guaranteed to work anymore. With that being said, almost all calls to produce will wind up putting the edm::EventSetup into the exact same memory location on the stack each call so it just happens to work. That is probably why the tests in #25783 succeed.

[slava77]

+1

for #25838 77eafe9

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show no differences

[fabiocos]

@ssekmen the change in fastsim looks obvious and minimal, could you please check and comment or sign it?

[ssekmen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1