Data relvals offline GTs

[ahmad3213]

Code has been changed so that Data 2016, 2017 and 2018 Run A,B,C relvals now uses offline Global Tags by default instead of Prompt like GT. Data 2018 D still using Prompt like GT, as desired.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26281/8965

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @ahmad3213 (Muhammad Ahmad ) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[zhenhu]

please test workflow 136.849,136.850,136.8501,136.8561,136.864,136.865,136.878,136.879,136.885,136.891,137.8,136.828,136.835,136.769,136.775

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33828/console Started: 2019/03/28 15:22

[cmsbuild]

-1

Tested at: a69edec

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26281/33828/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

The relvals timed out after 4 hours.

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[zhenhu]

please test workflow 136.849,136.850,136.8501,136.8561

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26281/9017

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #26281 was updated. @cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please check and sign again.

[zhenhu]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33906/console Started: 2019/04/02 14:58

[cmsbuild]

+1
Tested at: d4ce4e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26281/33906/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d4ce4e9
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26281/33906/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26281/33906/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26281/33906/summary.html

The workflows 136.85 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2662 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2983008
• DQMHistoTests: Total failures: 1275
• DQMHistoTests: Total nulls: 7
• DQMHistoTests: Total successes: 2981536
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 668.52 KiB( 30 files compared)
• DQMHistoSizes: changed ( 136.788 ): 672.445 KiB Reference/Run 297557
• DQMHistoSizes: changed ( 136.788 ): -2.789 KiB L1T/L1TStage2uGT
• DQMHistoSizes: changed ( 136.788 ): -1.055 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 136.788 ): -0.082 KiB JetMET/SUSYDQM
• Checked 129 log files, 14 edm output root files, 32 DQM output files

[zhenhu]

+1

[fabiocos]

@kpedro88 this is not strictly upgrade, still your signature is needed. I assume you ask to squash the first three commits into a single one

[kpedro88]

yes, the first three commits should be one commit. The modification to upgrade lines was improperly copied from another branch and then improperly removed.

[zhenhu]

Hi @kpedro88 , do you suggest we should make a new PR wrt to most recent IB?

[kpedro88]

either squash this current branch or overwrite it with a clean commit. (there is no real need to make a new PR.)

[fabiocos]

@zhenhu it is enough to make

git cms-rebase-topic ahmad3213:data_relvals_Offline_GTs
git reset --hard HEAD~3
git merge --squash "HEAD@{1}"
git commit 

There is no valuable information in the several updates done. Could you please update so as we close quickly this PR?

[fabiocos]

@ahmad3213 @prebello @zhenhu can we finalize this? The suggested update is really minimal

[fabiocos]

after #26417 has been opened (not really necessary, but authors preferred this way), this PR may be closed

[zhenhu]

#26417 has been merged. This one can be closed now.