Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data relvals 2018 ABC,2016 and 2017 relvals using Offline GTs now by … #26417

Merged
merged 1 commit into from Apr 11, 2019

Conversation

ahmad3213
Copy link
Contributor

Hi,
I have been created this new PR following the discussion from old PR#26281 where there was conflicts. This time i started off from most recent IB available (CMSSW_10_6_X_2019-04-09-1100) and also made just one commit for all the changes.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26417/9186

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahmad3213 (Muhammad Ahmad ) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

@ahmad3213 thanks, using the commands I have suggested it was not necessary to open a new PR, but ok.

@fabiocos
Copy link
Contributor

please test workflow 136.849,136.850,136.885,136.886,137.8

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34110/console Started: 2019/04/10 09:32
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34115/console Started: 2019/04/10 12:20

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26417/34115/summary.html

The workflows 136.85 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26417/136.885_RunHLTPhy2018D+RunHLTPhy2018D+HLTDR2_2018+RECODR2_2018reHLT_Prompt+HARVEST2018_Prompt
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26417/136.886_RunEGamma2018D+RunEGamma2018D+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM_Prompt
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26417/137.8_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+RunEGamma2018D+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM_MULTIRUN

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2666 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2983688
  • DQMHistoTests: Total failures: 1275
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 2982216
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 668.52 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 136.788 ): 672.445 KiB Reference/Run 297557
  • DQMHistoSizes: changed ( 136.788 ): -2.789 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 136.788 ): -1.055 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 136.788 ): -0.082 KiB JetMET/SUSYDQM
  • Checked 129 log files, 14 edm output root files, 32 DQM output files

@zhenhu
Copy link
Contributor

zhenhu commented Apr 10, 2019

+1

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e80c369 into cms-sw:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants