Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plots to monitor pixel clusterrepair algorithm #26324

Merged
merged 1 commit into from Apr 4, 2019

Conversation

arossi83
Copy link
Contributor

@arossi83 arossi83 commented Apr 2, 2019

PR description:

Some PixelPhase1 DQM plots added in order to monitor the performances of the Pixel Cluster Repair algorithm.

PR validation:

Code as been tested on MC ttbar data.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26324/9027

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

A new Pull Request was created by @arossi83 (Alessandro Rossi) for master.

It involves the following packages:

DQM/SiPixelPhase1Track

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno, @jandrea this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33923/console Started: 2019/04/03 11:28

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2019

@fabiocos this PR is going to help validate the feature introduced in #26263

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26324/33923/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 5739.591 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 10042.0,... ): 521.781 KiB PixelPhase1/Tracks
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants