Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Residuals plots and fix monitoring plots for Pixel ClusterRepairs #26430

Merged
merged 1 commit into from Apr 12, 2019

Conversation

arossi83
Copy link
Contributor

PR description:

Some additional DQM plots to monitor Pixel ClusterRepairs (introduced in #26263) and small fix to already present ones (introduced in #26324)

PR validation:

Standard runTheMatrix sequence

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26430/9211

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arossi83 (Alessandro Rossi) for master.

It involves the following packages:

Alignment/OfflineValidation
DQM/SiPixelPhase1Track

@andrius-k, @kmaeshima, @christopheralanwest, @schneiml, @tocheng, @cmsbuild, @franzoni, @jfernan2, @fioriNTU, @pohsun can you please review it and eventually sign? Thanks.
@hdelanno, @adewit, @tlampen, @tocheng, @fioriNTU, @jandrea, @mschrode, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fioriNTU
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 11, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34149/console Started: 2019/04/11 12:21

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@pohsun
Copy link

pohsun commented Apr 11, 2019

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26430/34149/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 433
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139865
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1069.189 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 97.199 KiB PixelPhase1/Tracks
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fioriNTU
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

DQM differences are in the PixelPhase1 sector, as expected rom the PR

@cmsbuild cmsbuild merged commit 5b7b34f into cms-sw:master Apr 12, 2019
@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34393/console Started: 2019/04/29 09:53

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26430/34393/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants