First attempt of premixing for MTD #26332
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26332/9040
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: DataFormats/FTLDigi @perrotta, @civanch, @mdhildreth, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
| value = cms.vstring( 'keep *_mix_FTLBarrel_*','keep *_mix_FTLEndcap_*','keep *_mix_InitialVertices_*' ) | ||
| ) | ||
| # For premixing switch the sim digi collections to the ones including pileup | ||
| # Unsure what to do with InitialVertices, they don't seem to be consumed downstream? |
There was a problem hiding this comment.
@lgray @pmeridian @fabiocos @casarsa please clarify the use (if any) of InitialVertices
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26332/9042
|
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
Here is a comparison of 100 ttbar+35PU events including the validation code from #26347 (+ the necessary customization for premixing) As some examples here are BTL SimDigis |
|
+upgrade |
|
+1
|
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@casarsa FYI |
|
+1 |
PR description:
This PR makes the first attempt to implement premixing for MTD. As the SimHit accumulation approach is similar to HGCal, the premixing approach is as well similar. A few details are different-enough though so that no code can be easily re-used (e.g. "MTD cell" indexing uses row and column indices in addition to DetId, and the exact way to fill
MTDCellInfodiffers fromHGCCellInfo).Basically in stage1
MTDSimHitDataAccumulatoris converted toPMTDSimAccumulatorby packing each "non-zero" elementMTDCellInfoto 11 bits.Elements of
MTDCellInfo[0](energy) are packed withlogintpack::pack16log()to the range 1e-4..1e6 yielding ~1.3 % precision. I found this range by printing out values on 200 PU, so likely there is room for further tuning (from printouts I noticed that especially on the higher side the values seem to be quantized with much larger steps than 1.3 %).Elements of
MTDCellInfo[1](time of flight) appeared to be limited roughly to the range of 0-26, so those values are packed linearly on that range.PR validation:
Tested in 10_4_0_mtd5 (and then rebased on 10_6_0_pre3, compiled, and limited matrix runs). I have here comparison of 4D-vertices validation on 10 ttbar+PU35 events
http://mkdev7.cern.ch:8081/dqm/relval/start?runnr=1;dataset=/RelValTTbar_14/CMSSW_10_4_0_mtd5-PU35_2023d35_10ev_classical_v1-v1/DQMIO;sampletype=offline_relval;filter=all;referencepos=ratiooverlay;referenceshow=all;referencenorm=True;referenceobj1=other%3A%3A/RelValTTbar_14/CMSSW_10_4_0_mtd5-PU35_2023d35_10ev_premixing_v2-v1/DQMIO%3A%3A;referenceobj2=none;referenceobj3=none;referenceobj4=none;search=;striptype=object;stripruns=;stripaxis=run;stripomit=none;workspace=Everything;size=M;root=Vertexing/PrimaryVertexV/offlinePrimaryVertices4D;focus=Vertexing/PrimaryVertexV/offlinePrimaryVertices4D/RecoAllAssoc2GenMatched_PullY;zoom=no;
and (e.g. reco-only) distributions look reasonable
Further testing (larger statistics, lower-level variables) would be useful,
@kpedro88 @mdhildreth @fabiocos