MTD validation package

[casarsa]

This is the first implementation of a DQM/validation package for the MTD system:
Validation/MtdValidation
It is based on the DQMEDAnalyzer, it fills histograms for both the BTL and the ETL detectors at SIM, DIGI, and RECO steps.

This package has been tested with the TTbar 2023D41 workflow.
It adds ~700 kB of data to the DQM output file:
475.40 KiB MTD/ETL
231.58 KiB MTD/BTL

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26347/9063

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @casarsa (Massimo Casarsa) for master.

It involves the following packages:

Validation/Configuration
Validation/MtdValidation

The following packages do not have a category, yet:

Validation/MtdValidation
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[andrius-k]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33952/console Started: 2019/04/04 10:40

[cmsbuild]

-1

Tested at: e086204

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26347/33952/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[fabiocos]

@casarsa @andrius-k This MTD code is not present for D17, we need to call it only for the appropriate phase2 eras (where timing_layer is present). This should enter in globalValidation_cff at the bottom, I would say. For next round please run also wf 29034.0 (the latest D41 scenario)

[makortel]

Thanks, I tried this PR with premixing (#26332), and have some comments based on that experiment (I did not repeat everything that seems to repeat between all the modules).

[makortel]

This MTD code is not present for D17, we need to call it only for the appropriate phase2 eras (where timing_layer is present). This should enter in globalValidation_cff at the bottom, I would say. For next round please run also wf 29034.0 (the latest D41 scenario)

Maybe the whole phase2 validation configuration could be reorganized as a single sequence in globalValidation_cff with modifiers adding detector-specific modules as is done for phase0+1?

[fabiocos]

@casarsa if I am not mistaken, for bookProfile you always keep the default option that should be spread, we need to understand whether it is exactly what is needed

[cmsbuild]

Pull request #26347 was updated. @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34262/console Started: 2019/04/17 20:22

[cmsbuild]

+1
Tested at: 06a38d6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26347/34262/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26347/34262/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3142783
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3142585
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 707.852 KiB( 31 files compared)
• DQMHistoSizes: changed ( 27434.0 ): 476.275 KiB MTD/ETL
• DQMHistoSizes: changed ( 27434.0 ): 231.576 KiB MTD/BTL
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

@andrius-k @civanch @casarsa as far as I can see for the first version it should be now ok to be merged, allowing to regularly monitor changes in MTD from now on

@kpedro88 FYI

[civanch]

+1

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

also a quick igprof memory test shows that the MTD validation looks to be irrelevant in the overall 29034.0 step3 budget.

[fabiocos]

+1