Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running code-format for simulation #26715

Merged
merged 3 commits into from
May 10, 2019
Merged

Running code-format for simulation #26715

merged 3 commits into from
May 10, 2019

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented May 9, 2019

Applying code-format for CMSSW category simulation.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/198//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

Same as #26674 but with correct CMS clang-format customization (see #26686)

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

please test

@cmsbuild cmsbuild added this to the CMSSW_10_6_X milestone May 9, 2019
@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26715/9701

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/107/console Started: 2019/05/09 06:30

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DataFormats/CSCDigi
DataFormats/CTPPSDetId
DataFormats/EcalDetId
DataFormats/FP420Digi
DataFormats/GeometryCommonDetAlgo
DataFormats/RPCDigi
DataFormats/SiPixelDetId
DataFormats/SiPixelRawData
DataFormats/SiStripDigi
SimG4CMS/Muon
SimG4Core/Physics
SimGeneral/PileupInformation

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @makortel, @jan-kaspar, @rovere, @argiro, @dildick, @ptcox, @alesaggio, @mmusich, @VinInn, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

+1
Tested at: 57cea53
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-868e6c/107/summary.html

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-868e6c/107/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor

civanch commented May 10, 2019

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@fabiocos
Update ES_PixelFEDChannelCollectionMap.cc
c59f484 
Restore the spacing provided by clang-format
@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26715/9742

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

Pull request #26715 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 10, 2019 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/157/console Started: 2019/05/10 22:19

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@civanch I just fixed the conflict with #26708

@cmsbuild cmsbuild merged commit b3a035f into master May 10, 2019
@cmsbuild
Copy link
Contributor Author

-1

Tested at: c59f484

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6c72504
66cf5e6
3252ab4
c079135
2ef6419
848a8a2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26715/157/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26715/157/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-868e6c/157/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6c72504
66cf5e6
3252ab4
c079135
2ef6419
848a8a2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26715/157/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26715/157/git-merge-result

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-868e6c/157/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-868e6c/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 132
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211628
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar smuzaffar deleted the code-format-simulation-bc9e9d branch May 31, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available orp-approved pending-signatures simulation-pending tests-rejected
Projects
None yet
Milestone
CMSSW_10_6_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmsbuild @civanch @fabiocos