-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataFormats/SiPixelDetId: fix for undefined unordered_map when compiling with clang 4.0.1 and macos10.9.X SDK under Conda #26708
DataFormats/SiPixelDetId: fix for undefined unordered_map when compiling with clang 4.0.1 and macos10.9.X SDK under Conda #26708
Conversation
…ing with clang 4.0.1 and macos10.9.X SDK under Conda
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26708/9693
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: DataFormats/SiPixelDetId @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@smuzaffar This is the other change I had to make to compile under Conda. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Adding this #include allows this to compile under Conda which uses clang4.0.1 and macOS10.9.x SDK.