Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFormats/SiPixelDetId: fix for undefined unordered_map when compiling with clang 4.0.1 and macos10.9.X SDK under Conda #26708

Merged
merged 1 commit into from
May 10, 2019
Merged

Conversation

gartung
Copy link
Member

@gartung gartung commented May 9, 2019

Adding this #include allows this to compile under Conda which uses clang4.0.1 and macOS10.9.x SDK.

…ing with clang 4.0.1 and macos10.9.X SDK under Conda
@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26708/9693

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

DataFormats/SiPixelDetId

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented May 9, 2019

@smuzaffar This is the other change I had to make to compile under Conda.

@civanch
Copy link
Contributor

civanch commented May 9, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/122/console Started: 2019/05/09 13:10

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44dc92/122/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor

civanch commented May 10, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2ef6419 into cms-sw:master May 10, 2019
@gartung gartung deleted the DataFormats-SiPixelDetId-clang401fix branch June 24, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants