Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default beamspot from "RoundOpticsHighSigmaZ" to "RoundOpticsLowSigmaZ" #26968

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

christopheralanwest
Copy link
Contributor

PR description:

PC has requested a change in the default beamspot in 2021 realistic workflows from "RoundOpticsHighSigmaZ" to "RoundOpticsLowSigmaZ". This PR implements the change in both conditions:

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2021_realistic_v5/106X_upgrade2021_realistic_v4

and validation workflows.

PR validation:

runTheMatrix.py --what upgrade -l 11825.0 --ibeos generates workflows that use the updated beamspot and runs to completion.

if this PR is a backport please specify the original PR:

This PR will be backported to 10_6_X.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26968/10023

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation

@cmsbuild, @prebello, @zhenhu, @christopheralanwest, @tocheng, @pgunnell, @franzoni, @kpedro88, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/553/console Started: 2019/05/28 16:22

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-487550/553/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2629 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3209232
  • DQMHistoTests: Total failures: 9407
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3199491
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • The intended beamspot is specified in workflow 11624.0 GEN-SIM
  • Changes are present only in the 2021 realistic scenario (workflow 11624.0)
  • Changes are seen in many comparison test histograms as the GEN-SIM is changed

@kpedro88
Copy link
Contributor

+upgrade

@fabiocos
Copy link
Contributor

fabiocos commented Jun 3, 2019

@prebello @zhenhu any objection? Otherwise could you please sign it? DQM differences are present only for the 2021 workflow, as expected

@zhenhu
Copy link
Contributor

zhenhu commented Jun 3, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 3, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants