Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect string comparison method in DQM bin by bin comparison tool #27085

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

andrius-k
Copy link

PR description:

A fix to an issue comparing string monitor elements.

PR validation:

This PR vas validated locally.

@andrius-k
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27085/10170

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/724/console Started: 2019/06/03 12:55

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

A new Pull Request was created by @andrius-k (Andrius) for master.

It involves the following packages:

DQMServices/FileIO

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

+1
Tested at: 19932db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c76983/724/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c76983/724/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c76983/724/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c76983/724/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2629 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3210678
  • DQMHistoTests: Total failures: 9399
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3200945
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 4, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 4, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants