Returning a lost method call in DQM bin by bin comparison tool

[andrius-k]

PR description:

Returning the somehow lost method call. This should have been committed here: #27085

PR validation:

A tool was validated locally.

[cmsbuild]

The code-checks are being triggered in jenkins.

[andrius-k]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27093/10184

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/746/console Started: 2019/06/04 16:04

[cmsbuild]

A new Pull Request was created by @andrius-k (Andrius) for master.

It involves the following packages:

DQMServices/FileIO

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: a28ecc5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f9f2d/746/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f9f2d/746/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3210222
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3209886
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@andrius-k sorry, was this PR supposed to solve the issue of the equal number of histograms added and deleted? It does not seem the case... Could you please clarify?

[andrius-k]

@fabiocos yes, it should fix the mentioned issue. What makes you think it doesn't? This change was somehow lost and had to go together with #27085

[fabiocos]

@andrius-k well, looking at the output of this PR the problem still seems present. @smuzaffar is the bot using the BASE_RELEASE version?

[fabiocos]

+1

[smuzaffar]

@fabiocos , yes comparison job uses the BASE_RELEASE version.