-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scenario Run3 to Configuration/DataProcessing #27537
Conversation
A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_6_X. It involves the following packages: Configuration/DataProcessing @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
from Configuration.Eras.Era_Run3_cff import Run3 | ||
from Configuration.DataProcessing.Impl.cosmics import cosmics | ||
|
||
class cosmicsEra_Run3_2021(cosmics): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why 2021?
the scenarios in this directory should match exactly the era name at the end.
Comparison job queued. |
Pull request #27537 was updated. @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again. |
Pull request #27537 was updated. @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again. |
please abort |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Comparison is ready Comparison Summary:
|
+operations |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will be automatically merged. |
PR description:
Extend Configuration/DataProcessing including Era_Run3 as Run3_2021. HI and special settings are not considered for the time being.
No change to Era_Run3 is done, I let the move to year-based eras as discussed with @boudoul and @kpedro88 for a separate PR, given the urgency of this one.
Rebased version of #27536 on 10_6_X .
PR validation:
The unit test passes, the code is a direct extension of the Run2 counterpart.
if this PR is a backport please specify the original PR: #27536