Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.6.X] Fix simulation of the pixel bad components on the FED channel basis for PreMixing #27916

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 2, 2019

backport of #27912

PR description:

During the CMSSW_11_0_0_pre5 validation it was noticed that the per-FED channel Pixel bad components handling (a.k.a. "stuck-TBM" simulation) introduced in PR #25466, was not working in the premixing case (cf. valDB report ).
This PR fixes the premixing case.

PR validation:

PR validation has been carried out by @tsusa by comparing the pixel valid hit occupancy maps in the baseline CMSSW_11_0_X branch for premixing with and without this PR and compared with classical mixing (tested earlier to work correctly).
I report here one example for BPix Layer 1:

image

more information is contained in this presentation.

if this PR is a backport please specify the original PR:

backport of #27912

cc:
@tsusa @veszpv @tvami

@mmusich mmusich changed the title [[10.6.X] Fix simulation of the pixel bad components on the FED channel basis for PreMixing [10.6.X] Fix simulation of the pixel bad components on the FED channel basis for PreMixing Sep 2, 2019
@cmsbuild cmsbuild added this to the CMSSW_10_6_X milestone Sep 2, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2019

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_10_6_X.

It involves the following packages:

SimTracker/SiPixelDigitizer

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 2, 2019

type bugfix

@civanch
Copy link
Contributor

civanch commented Sep 3, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2331/console Started: 2019/09/03 17:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-33dd82/2331/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2057 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211049
  • DQMHistoTests: Total failures: 5510
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3205204
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor

civanch commented Sep 4, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3e9ea98 into cms-sw:CMSSW_10_6_X Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants