Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AAA fallback to DQMRootSource #28064

Merged
merged 3 commits into from
Sep 25, 2019

Conversation

dan131riley
Copy link

PR description:

This PR adds AAA fallback file open logic to the DQMRootSource, resolving issue #27724. The logic is patterned on RootInputFileSequence, which is structurally very similar. There is some annoying code repetition because of slight differences in the logic for the main and fallback case.

PR validation:

The fallback logic was tested with the test case from #27724. Fallback logic worked as expected:

24-Sep-2019 17:02:14 CEST  Initiating request to open file root://eoscms.cern.ch//eos/cms/store/data/Run2018D/ZeroBias/DQMIO/PromptReco-v2/000/323/940/00000/9F411A2F-9C94-D54F-894B-83D60BF55C41.root
%MSG-w XrdAdaptorInternal:  AfterModBeginStream 24-Sep-2019 17:02:16 CEST  BeforeEvents
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/data/Run2018D/ZeroBias/DQMIO/PromptReco-v2/000/323/940/00000/9F411A2F-9C94-D54F-894B-83D60BF55C41.root.
%MSG
%MSG-w XrdAdaptorInternal:  AfterModBeginStream 24-Sep-2019 17:02:16 CEST  BeforeEvents
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/data/Run2018D/ZeroBias/DQMIO/PromptReco-v2/000/323/940/00000/9F411A2F-9C94-D54F-894B-83D60BF55C41.root?tried=.
%MSG
24-Sep-2019 17:02:16 CEST  Initiating request to open fallback file root://xrootd-cms.infn.it//store/data/Run2018D/ZeroBias/DQMIO/PromptReco-v2/000/323/940/00000/9F411A2F-9C94-D54F-894B-83D60BF55C41.root
%MSG-w XrdAdaptor:  AfterModBeginStream 24-Sep-2019 17:02:18 CEST BeforeEvents
Data is served from T2_ES_IFCA instead of original site infn.it
%MSG
24-Sep-2019 17:02:20 CEST  Successfully opened fallback file root://xrootd-cms.infn.it//store/data/Run2018D/ZeroBias/DQMIO/PromptReco-v2/000/323/940/00000/9F411A2F-9C94-D54F-894B-83D60BF55C41.root

and it was confirmed that the FJR contained the correct fallback PFN.

A limited matrix is in process, but no regressions are expected as the matrix test cases do not use remote DQM files so the fallback logic would not be engaged.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28064/12006

  • This PR adds an extra 20KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dan131riley (Dan Riley) for master.

It involves the following packages:

DQMServices/FwkIO

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 24, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2653/console Started: 2019/09/24 17:56

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db90f0/2653/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2958092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2957750
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4c0913f into cms-sw:master Sep 25, 2019
@dan131riley dan131riley deleted the DQMRootSource-fallback-file branch September 30, 2019 17:20
schneiml added a commit to schneiml/cmssw that referenced this pull request Nov 27, 2019
Using commit 70fc23c on his "new
DQMstore" branch.

This might revert changes from cms-sw#28064, needs to be fixed later.
schneiml added a commit to schneiml/cmssw that referenced this pull request Nov 27, 2019
schneiml added a commit to schneiml/cmssw that referenced this pull request Dec 6, 2019
Using commit 70fc23c on his "new
DQMstore" branch.

This might revert changes from cms-sw#28064, needs to be fixed later.
schneiml added a commit to schneiml/cmssw that referenced this pull request Dec 6, 2019
schneiml added a commit to schneiml/cmssw that referenced this pull request Dec 9, 2019
Using commit 70fc23c on his "new
DQMstore" branch.

This might revert changes from cms-sw#28064, needs to be fixed later.
schneiml added a commit to schneiml/cmssw that referenced this pull request Dec 9, 2019
schneiml added a commit to schneiml/cmssw that referenced this pull request Dec 12, 2019
Using commit 70fc23c on his "new
DQMstore" branch.

This might revert changes from cms-sw#28064, needs to be fixed later.
schneiml added a commit to schneiml/cmssw that referenced this pull request Dec 12, 2019
schneiml added a commit to schneiml/cmssw that referenced this pull request Dec 18, 2019
Using commit 70fc23c on his "new
DQMstore" branch.

This might revert changes from cms-sw#28064, needs to be fixed later.
schneiml added a commit to schneiml/cmssw that referenced this pull request Dec 18, 2019
schneiml added a commit to schneiml/cmssw that referenced this pull request Jan 14, 2020
Using commit 70fc23c on his "new
DQMstore" branch.

This might revert changes from cms-sw#28064, needs to be fixed later.
schneiml added a commit to schneiml/cmssw that referenced this pull request Jan 14, 2020
schneiml added a commit to schneiml/cmssw that referenced this pull request Jan 14, 2020
Using commit 70fc23c on his "new
DQMstore" branch.

This might revert changes from cms-sw#28064, needs to be fixed later.
schneiml added a commit to schneiml/cmssw that referenced this pull request Jan 14, 2020
schneiml added a commit to schneiml/cmssw that referenced this pull request Jan 17, 2020
Using commit 70fc23c on his "new
DQMstore" branch.

This might revert changes from cms-sw#28064, needs to be fixed later.
schneiml added a commit to schneiml/cmssw that referenced this pull request Jan 17, 2020
schneiml added a commit to schneiml/cmssw that referenced this pull request Jan 22, 2020
Using commit 70fc23c on his "new
DQMstore" branch.

This might revert changes from cms-sw#28064, needs to be fixed later.
schneiml added a commit to schneiml/cmssw that referenced this pull request Jan 22, 2020
schneiml added a commit to schneiml/cmssw that referenced this pull request Jan 22, 2020
Using commit 70fc23c on his "new
DQMstore" branch.

This might revert changes from cms-sw#28064, needs to be fixed later.
schneiml added a commit to schneiml/cmssw that referenced this pull request Jan 22, 2020
schneiml added a commit to schneiml/cmssw that referenced this pull request Feb 3, 2020
Using commit 70fc23c on his "new
DQMstore" branch.

This might revert changes from cms-sw#28064, needs to be fixed later.
schneiml added a commit to schneiml/cmssw that referenced this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants