-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AAA fallback to DQMRootSource #28064
Add AAA fallback to DQMRootSource #28064
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28064/12006
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages: DQMServices/FwkIO @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Using commit 70fc23c on his "new DQMstore" branch. This might revert changes from cms-sw#28064, needs to be fixed later.
Not tested yet.
Using commit 70fc23c on his "new DQMstore" branch. This might revert changes from cms-sw#28064, needs to be fixed later.
Not tested yet.
Using commit 70fc23c on his "new DQMstore" branch. This might revert changes from cms-sw#28064, needs to be fixed later.
Not tested yet.
Using commit 70fc23c on his "new DQMstore" branch. This might revert changes from cms-sw#28064, needs to be fixed later.
Not tested yet.
Using commit 70fc23c on his "new DQMstore" branch. This might revert changes from cms-sw#28064, needs to be fixed later.
Not tested yet.
Using commit 70fc23c on his "new DQMstore" branch. This might revert changes from cms-sw#28064, needs to be fixed later.
Not tested yet.
Using commit 70fc23c on his "new DQMstore" branch. This might revert changes from cms-sw#28064, needs to be fixed later.
Not tested yet.
Using commit 70fc23c on his "new DQMstore" branch. This might revert changes from cms-sw#28064, needs to be fixed later.
Not tested yet.
Using commit 70fc23c on his "new DQMstore" branch. This might revert changes from cms-sw#28064, needs to be fixed later.
Not tested yet.
Using commit 70fc23c on his "new DQMstore" branch. This might revert changes from cms-sw#28064, needs to be fixed later.
Not tested yet.
Using commit 70fc23c on his "new DQMstore" branch. This might revert changes from cms-sw#28064, needs to be fixed later.
Not tested yet.
PR description:
This PR adds AAA fallback file open logic to the DQMRootSource, resolving issue #27724. The logic is patterned on RootInputFileSequence, which is structurally very similar. There is some annoying code repetition because of slight differences in the logic for the main and fallback case.
PR validation:
The fallback logic was tested with the test case from #27724. Fallback logic worked as expected:
and it was confirmed that the FJR contained the correct fallback PFN.
A limited matrix is in process, but no regressions are expected as the matrix test cases do not use remote DQM files so the fallback logic would not be engaged.