New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NanoAODv6 updates, part 1 #28103
NanoAODv6 updates, part 1 #28103
Conversation
Update master-cmsswmaster to CMSSW_11_0_0_pre6
…, cfr. OverlapFilterIsoMu
Remove trigger object redundancy of OverlapFilterIsoEle bits
Update master-cmsswmaster to CMSSW_11_0_0_pre9
…correlated DeepDoubleX taggers to make it explicit
…ggers and new explicit names for non-mass-decoreelated taggers)
Port recent pull requests to master
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28103/12103
|
A new Pull Request was created by @peruzzim for master. It involves the following packages: Configuration/Eras @kpedro88, @peruzzim, @cmsbuild, @franzoni, @fgolf, @santocch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 1325.6,1325.7,1325.8,1329.1,136.7722,136.7952,136.8521 testing all NANOAOD workflows explicitly |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+xpog all as expected, changes in NANOAOD |
+1 |
Could you please review this? It would help speeding up backports to have it merged soon. Thanks! |
@@ -0,0 +1,40 @@ | |||
#ifndef PhysicsTools_NanoAOD_EventStringOutputBranches_h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peruzzim is there a special reason not to have this file integrated inside the .cc
plugin implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it because I am including this header in PhysicsTools/NanoAOD/plugins/NanoAODOutputModule.cc
.
If you have a suggestion on how this should be done differently, please let me know and I'll implement it in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peruzzim ok, you are correct, I agree
+operations the update of Eras is coherent with the purpose and implementation of the PR |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This pull request includes the bulk of NanoAOD updates for the upcoming V6 version.
Further minor tunings can be expected in a second pull request to follow.
Backports will follow to 10_2_X and 10_6_X.
PR validation:
This version was validated using the standard NanoAOD integration setup (running on MiniAOD created in 80X, 94X, 102X, 106X).