Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Patatrack process modifiers and workflows #28522

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 2, 2019

PR description:

Add the pixelNtupleFit process modifier, that will be used to customise the Pixel-only tracks to use the ntuplet fit developed as part of the Patatrack workflows.

Add the "gpu" process modifer, that can be used to enable offloading of available modules to run on GPUs.

Add the first Patatrack workflows (currently just a placeholder).

PR validation:

Tested as part of the full Patatrack integration.

Add the "pixelNtupleFit" process modifier, that will be used to
customise the Pixel-only tracks to use the ntuplet fit developed as part
of the Patatrack workflows.

Add the "gpu" process modifer, that can be used to enable offloading of
available modules to run on GPUs.

Add the first Patatrack workflows (currently just a placeholder).
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2019

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 2, 2019

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28522/12987

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3731/console Started: 2019/12/02 18:07

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2019

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

Configuration/ProcessModifiers
Configuration/PyReleaseValidation

@cmsbuild, @chayanit, @zhenhu, @kpedro88, @pgunnell, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ed1dc/3731/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-2ed1dc/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793497
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Dec 3, 2019

+upgrade

@fabiocos
Copy link
Contributor

fabiocos commented Dec 4, 2019

please test workflow 136.885502,10824.502

I expect no surprise, a for the time being GPU is just a placeholder

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3800/console Started: 2019/12/04 18:24

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ed1dc/3800/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-2ed1dc/10824.502_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFullPatatrack_PixelOnlyGPU_2018+HARVESTFullPatatrack_PixelOnlyGPU_2018
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-2ed1dc/136.885502_RunHLTPhy2018D+RunHLTPhy2018D+HLTDR2_2018+RECODR2_2018reHLT_Patatrack_PixelOnlyGPU+HARVEST2018_pixelTrackingOnly

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

+operations

the additions look coherent with the purpose of the PR and the added workflows look functional

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 971c06e into cms-sw:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants