Migrate 10 EDFilters in GenFilters from legacy #28991
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28991/13826
|
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: GeneratorInterface/GenFilters @SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test fyi @Dr15Jones @makortel |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 15ff017 CMSSW: CMSSW_11_1_X_2020-02-18-1100 I found follow errors while testing this PR Failed tests: ClangBuild
I found compilation warning while trying to compile with clang. Command used: See details on the summary page. |
|
Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
10 more legacy EDFilters in the GenFilters package migrated from being legacy types to global or one types. This is the second in a series of such PRs (more are on the way). There is a considerable amount of cleanup mixed in with this. Headers fixed, commented code removed, cout lines removed, event counters removed, .h content moved to .cc files, destructors just defaulted, esConsumes migration done for one module... The intent is nothing has been done that would change the filter behavior and in fact the changes to the algorithmic code in the filter methods are very small. I didn't touch any complicated logical code.
wddgit
force-pushed
the
convertLegacyFilters2
branch
from
15ff017
to
3ed62ec
Compare
cmsbuild
added
code-checks-pending
comparison-pending
tests-pending
and removed
code-checks-approved
comparison-notrun
tests-rejected
labels
|
Pull request #28991 was updated. @SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please check and sign again. |
|
please test Force pushed a commit that fixed the problem clang noticed. It was related to the std::abs function. Mostly the fix was that I restored "using namespace std" everywhere I had deleted it and also put a few other related things back the way they were before. A few less cleanup changes now. |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@alberto-sanchez @agrohsje @efeyazgan @mkirsano @qliphy @SiewYan |
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
10 more legacy EDFilters in the GenFilters package
migrated from being legacy types to global or one
types. This is the second in a series of such PRs
(more are on the way).
There is a considerable amount of cleanup mixed in with
this. Headers fixed, commented code removed, cout lines
removed, event counters removed, .h content moved to
.cc files, destructors just defaulted, esConsumes migration
done for one module...
The intent is nothing has been done that would change
the filter behavior and in fact the changes to the
algorithmic code in the filter methods are very small.
I didn't touch any complicated logical code.
PR validation:
Relying on existing tests. Behavior should not change.