Migrate 17 EDFilters in GenFilters from legacy #29048
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29048/13914
|
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: GeneratorInterface/GenFilters @SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29048/13933
|
|
please test rebase to fix trivial conflict, twice this PR deleted a line adjacent to a line deleted by the earlier PR in the SealModule.cc file. We want both lines deleted. Nothing else changed in the PR. |
|
The tests are being triggered in jenkins. |
|
Pull request #29048 was updated. @SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please check and sign again. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
There really was no change at all to this PR since it was approved. I just had to resolve a conflict because this PR deleted a line adjacent to a line the other recently merged PR deleted (in SealModule.cc). But it needs a new +1. |
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
17 more legacy EDFilters in the GenFilters package
migrated from being legacy types to global, stream,
or one types. This is the third in a series of such
PRs. It is possibly the last because the ones that
have not been migrated yet have been broken for years
and probably are not worth the effort to migrate.
There is a considerable amount of cleanup mixed in with
this. Headers fixed, commented code removed, cout lines
removed, event counters removed, .h content moved to
.cc files, destructors just defaulted, esConsumes migration
done...
The intent is nothing has been done that would change
the filter behavior and in fact the changes to the
algorithmic code in the filter methods are very small.
I didn't touch any complicated logical code.
PR validation:
Relying on existing tests. Behavior should not change.