Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pythia8ConcurrentHadronizerFilter when possible #29305

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Use Pythia8ConcurrentHadronizerFilter when the parameter ExternalDecays is not used.

PR validation:

No tests were performed.

Use Pythia8ConcurrentHadronizerFilter when the parameter
ExternalDecays is not used.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29305/14379

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Configuration/Generator

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 25, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5387/console Started: 2020/03/25 20:57

@cmsbuild
Copy link
Contributor

+1
Tested at: de04447
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6bd29/5387/summary.html
CMSSW: CMSSW_11_1_X_2020-03-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6bd29/5387/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692110
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691761
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Mar 26, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 53a33d7 into cms-sw:master Mar 27, 2020
@Dr15Jones Dr15Jones deleted the usePythia8ConcurrentHadronizerFilter branch March 30, 2020 15:00
colizz added a commit to colizz/cmssw that referenced this pull request Aug 5, 2021
…hon` to enable concurrent GEN

 Big backport from cms-sw#34710 following the same four-step rule. It also includes the backport of cms-sw#29305, cms-sw#33516, cms-sw#34463 with the same goal (these are never backported to 10_6_X)
colizz added a commit to colizz/cmssw that referenced this pull request Aug 5, 2021
…hon` to enable concurrent GEN

 Big backport from cms-sw#34710 following the same four-step rule. It also includes the backport of cms-sw#29305, cms-sw#33516, cms-sw#34463 with the same goal (these are never backported to 10_6_X)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants