implement concurrent ExternalLHEProducer technique #33516

SiewYan · 2021-04-23T16:55:09Z

PR description:

The concurrent version of ExternalLHEProducer is implemented for GEN workflows, LHE production + Hadronization mode.

No changed in output; expects improved CPU time.
None
https://twiki.cern.ch/twiki/bin/view/CMSPublic/WorkBookGenMultithread#Concurrent_ExternalLHEProducer
https://indico.cern.ch/event/894534/contributions/3827060/attachments/2030893/3398914/ExternalGeneratorFilter_for_Generators_Meeting.pdf
Modules prohibiting concurrent lumis in RelVal workflows #25090 (comment)

PR validation:

Ran on several workflow from relval_generator, relval_extendedgen with --nThreads 4, and it is a success.

SiewYan · 2021-04-23T16:57:42Z

please test workflow 512,547,548,555,513,551,556,514,552,554,515,516,517,518,519,520

cmsbuild · 2021-04-23T17:02:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33516/22266

This PR adds an extra 28KB to repository

cmsbuild · 2021-04-23T17:03:17Z

A new Pull Request was created by @SiewYan (Siewyan Hoh 何守仁) for master.

It involves the following packages:

Configuration/Generator

@SiewYan, @alberto-sanchez, @agrohsje, @mkirsano, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-04-23T17:06:30Z

-1

Failed Tests: Build Python3
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-106d73/14549/summary.html
COMMIT: 2fad785
CMSSW: CMSSW_12_0_X_2021-04-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33516/14549/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

#Python3

I found errors:

*** Error compiling 'src/Configuration/Generator/python/WTolNu012Jets_5f_LO_MLM_Madgraph_LHE_13TeV_cff.py'...

oops.

SiewYan · 2021-04-23T17:09:59Z

please test workflow 512,547,548,555,513,551,556,514,552,554,515,516,517,518,519,520

cmsbuild · 2021-04-23T17:13:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33516/22268

This PR adds an extra 28KB to repository

cmsbuild · 2021-04-23T17:14:16Z

Pull request #33516 was updated. @SiewYan, @alberto-sanchez, @agrohsje, @mkirsano, @GurpreetSinghChahal can you please check and sign again.

cmsbuild · 2021-04-23T20:03:50Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-106d73/14552/summary.html
COMMIT: 6eae1e1
CMSSW: CMSSW_12_0_X_2021-04-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33516/14552/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/512.0_DYTollJets_LO_Mad_13TeV_py8+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/513.0_WTolNuJets_LO_Mad_13TeV_py8+WTolNu012Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/514.0_GGToHgg_NLO_Pow_13TeV_py8+GGToH_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_Hgg_powhegEmissionVeto_pythia8+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/515.0_DYTollJets_LO_Mad_13TeV_py8_taupinu+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8_taupinu+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/516.0_WTolNuJets_LO_Mad_13TeV_py8_taupinu+WTolNu01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8_taupinu+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/517.0_VHToHtt_NLO_Pow_13TeV_py8_taupinu+VHToH_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_Httpinu_powhegEmissionVeto_pythia8+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/518.0_DYTollJets_LO_Mad_13TeV_py8_taurhonu+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8_taurhonu+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/519.0_WTolNuJets_LO_Mad_13TeV_py8_taurhonu+WTolNu01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8_taurhonu+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/520.0_VHToHtt_NLO_Pow_13TeV_py8_taurhonu+VHToH_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_Httrhonu_powhegEmissionVeto_pythia8+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/547.0_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+NANOGENFromGen
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/548.0_TTbar_Pow_LHE_13TeV+TTbar_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_powhegEmissionVeto2p_pythia8+NANOGENFromGen
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/551.0_TTbar012Jets_NLO_Mad_13TeV_py8+TTbar012Jets_5f_NLO_FXFX_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_aMCatNLO_FXFX_5f_max2j_max1p_LHE_pythia8+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/552.0_VHToHtt_NLO_Pow_13TeV_py8+VHToH_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_Htt_powhegEmissionVeto_pythia8+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/554.0_VBFToH4l_NLO_Pow_JHU_13TeV_py8+VBFToH_Pow_JHU4l_LHE_13TeV+Hadronizer_TuneCP5_13TeV_powhegEmissionVeto_pythia8+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/555.0_DYTollJets_NLO_Mad_13TeV_py8+DYToll012Jets_5f_NLO_FXFX_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_aMCatNLO_FXFX_5f_max2j_max0p_LHE_pythia8+HARVESTGEN2
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-106d73/556.0_TTbar_NLO_Pow_13TeV_py8+TTbar_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_powhegEmissionVeto2p_pythia8+HARVESTGEN2

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2877046
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2877017
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

qliphy · 2021-04-24T08:08:19Z

adding @colizz @Dr15Jones who may want to have a look.

colizz · 2021-04-24T08:25:38Z

@SiewYan @qliphy Thanks, it looks good to me.🙂

SiewYan · 2021-04-26T03:28:36Z

@qliphy , does comparisons for the following workflows were not done due to missing matrix map indicate the test is not done?

qliphy · 2021-04-26T05:50:54Z

@qliphy , does comparisons for the following workflows were not done due to missing matrix map indicate the test is not done?

The test runs for those workflows have been done without problem, but no comparisons done due to missing map (as those are for only limited worklows https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_X_2021-04-23-1100+106d73/42385/)

SiewYan · 2021-04-27T03:01:46Z

Thanks for clarification!

SiewYan · 2021-04-27T03:01:58Z

+1

cmsbuild · 2021-04-27T03:02:05Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-04-27T03:52:12Z

+1

silviodonato · 2021-04-28T08:59:46Z

This PR creates an error with Herwig7 (see #33544)

…hon` to enable concurrent GEN Big backport from cms-sw#34710 following the same four-step rule. It also includes the backport of cms-sw#29305, cms-sw#33516, cms-sw#34463 with the same goal (these are never backported to 10_6_X)

implement concurrent ExternalLHEProducer technique

2fad785

cmsbuild added this to the CMSSW_12_0_X milestone Apr 23, 2021

cmsbuild added code-checks-pending generators-pending orp-pending pending-signatures tests-pending labels Apr 23, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 23, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 23, 2021

cmsbuild added tests-rejected and removed tests-started labels Apr 23, 2021

Update WTolNu012Jets_5f_LO_MLM_Madgraph_LHE_13TeV_cff.py

6eae1e1

oops.

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-rejected labels Apr 23, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 23, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 23, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 23, 2021

cmsbuild added fully-signed and removed generators-pending pending-signatures labels Apr 27, 2021

cmsbuild added the generators-approved label Apr 27, 2021

cmsbuild added orp-approved and removed orp-pending labels Apr 27, 2021

cmsbuild merged commit 4112ef6 into cms-sw:master Apr 27, 2021

silviodonato mentioned this pull request Apr 28, 2021

Segfault in Herwig #33544

Closed

SiewYan deleted the from-CMSSW_11_3_0_pre6 branch May 3, 2021 03:07

colizz mentioned this pull request Jul 17, 2021

[10_6_X] Backport concurrent GEN utilities #34527

Merged

colizz mentioned this pull request Jul 31, 2021

Enable concurrent GEN in Configuration/Generator/python #34710

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement concurrent ExternalLHEProducer technique #33516

implement concurrent ExternalLHEProducer technique #33516

SiewYan commented Apr 23, 2021 •

edited

SiewYan commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

SiewYan commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

qliphy commented Apr 24, 2021

colizz commented Apr 24, 2021

SiewYan commented Apr 26, 2021

qliphy commented Apr 26, 2021

SiewYan commented Apr 27, 2021

SiewYan commented Apr 27, 2021

cmsbuild commented Apr 27, 2021

qliphy commented Apr 27, 2021

silviodonato commented Apr 28, 2021

implement concurrent ExternalLHEProducer technique #33516

implement concurrent ExternalLHEProducer technique #33516

Conversation

SiewYan commented Apr 23, 2021 • edited

PR description:

PR validation:

SiewYan commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

Build

SiewYan commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

Comparison Summary

qliphy commented Apr 24, 2021

colizz commented Apr 24, 2021

SiewYan commented Apr 26, 2021

qliphy commented Apr 26, 2021

SiewYan commented Apr 27, 2021

SiewYan commented Apr 27, 2021

cmsbuild commented Apr 27, 2021

qliphy commented Apr 27, 2021

silviodonato commented Apr 28, 2021

SiewYan commented Apr 23, 2021 •

edited