Extend the ECAL-only workflows with more PF and DQM modules

[fwyzard]

Update the default configuration of PFECALSuperClusterProducer

Update the default parameters provided by fillDescriptions() to those
used in the particleFlowSuperClusterECALMustache module.

Split particleFlowSuperClusterECAL_cfi into a cff and multiple cfi files

Each cfi file defines a single module and its customisations:

• particleFlowSuperClusterECALMustache
  (autogenerated by fillDescriptions)
• particleFlowSuperClusterECALBox
• particleFlowSuperClusterECALOnly
  (a clone of Mustache with various modifiers - see below)

The cff files includes the three cfi files.

particleFlowSuperClusteringSequence_cff is modified to use the cff file,
in order to make all modules available downstream.

Add an ECAL-only PF supercluster module

Add an ECAL-only configuration based on the default (Mustache) configuration,
using the "online" regression instead of "offline_v2", without the
requirement of tracks and vertices, and with updated
EB/EE/ES PF cluster thresholds.

Add ECAL-only PF modules to the ECAL-only reconstruction sequence

Rework ECAL-only DQM

Add an ECAL-only copy of ecalMonitorTask that uses the
ECAL-only PF superclusters from "particleFlowSuperClusterECALOnly" and
disables the "doExtra" plots to avoid the dependency on L1 trigger
objects.

Rework the ECAL-only DQM sequence to use this module, instead of
skipping the monitoring of the superclusters altogether.

[cmsbuild]

The code-checks are being triggered in jenkins.

[fwyzard]

Follow up to #29620.

[fwyzard]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29635/15021

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/StandardSequences/python/Reconstruction_cff.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5990/console Started: 2020/05/05 04:11

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

Configuration/StandardSequences
DQM/EcalMonitorTasks
DQMOffline/Ecal
RecoEcal/EgammaClusterProducers

@perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @silviodonato, @franzoni, @jfernan2, @fioriNTU, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Sam-Harper, @argiro, @makortel, @felicepantaleo, @jainshilpi, @GiacomoSguazzoni, @slomeo, @rovere, @lgray, @Martin-Grunewald, @sobhatta, @fabiocos, @lecriste, @afiqaize, @VinInn, @varuns23, @dgulhan, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: b2372d7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10bb51/5990/summary.html
CMSSW: CMSSW_11_1_X_2020-05-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10bb51/5990/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696239
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2695919
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[amassiro]

@rchatter

[cmsbuild]

+1
Tested at: 6abcdc2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10bb51/6231/summary.html
CMSSW: CMSSW_11_1_X_2020-05-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10bb51/6231/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-10bb51/10824.511_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFullPatatrack_ECALOnlyCPU_2018+HARVESTFullPatatrack_ECALOnlyCPU_2018

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697527
• DQMHistoTests: Total failures: 41
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697167
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[slava77]

+1

for #29635 6abcdc2

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show no relevant differences; the ecalOnly wf 10824.511 runs

[civanch]

+1

[silviodonato]

+operations

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1