Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECAL-only local reconstruction workflow #29620

Merged
merged 1 commit into from May 4, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 2, 2020

PR description:

Implement:

  • ECAL-only RAW-to-DIGI task and sequence
  • ECAL-only (no PF) reconsruction task and sequence
  • ECAL-only (no PF) offline DQM sequences
  • ECAL-only validation sequences

Add two new runTheMatrix.py modifiers:

  • .511 for ECAL-only reconstruction
  • .512 for ECAL-only reconstruction with GPU modifier

PR validation:

$ runTheMatrix.py -j4 -l 10824.511,10824.512

...

10824.511_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFullPatatrack_ECALOnlyCPU_2018+HARVESTFullPatatrack_ECALOnlyCPU_2018 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Mon May 4 13:01:40 2020-date Mon May 4 12:56:37 2020; exit: 0 0 0 0
10824.512_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFullPatatrack_ECALOnlyGPU_2018+HARVESTFullPatatrack_ECALOnlyGPU_2018 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Mon May 4 13:01:40 2020-date Mon May 4 12:56:37 2020; exit: 0 0 0 0
2 2 2 2 tests passed, 0 0 0 0 failed

Implement:
  - ECAL-only RAW-to-DIGI task and sequence
  - ECAL-only (no PF) reconsruction task and sequence
  - ECAL-only (no PF) offline DQM sequences
  - ECAL-only validation sequences

Add two new runTheMatrix.py modifiers:
  - .511 for ECAL-only reconstruction
  - .512 for ECAL-only reconstruction with GPU modifier
@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 2, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29620/14969

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5962/console Started: 2020/05/02 22:30

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/StandardSequences
DQMOffline/Configuration
DQMOffline/Ecal
Validation/Configuration

@pgunnell, @andrius-k, @silviodonato, @chayanit, @wajidalikhan, @schneiml, @civanch, @mdhildreth, @cmsbuild, @kmaeshima, @franzoni, @jfernan2, @fioriNTU, @fabiocos, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @apsallid, @lecriste, @argiro, @threus, @dgulhan, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

+1
Tested at: cd8f431
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-626513/5962/summary.html
CMSSW: CMSSW_11_1_X_2020-05-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-626513/5962/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695919
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented May 3, 2020

+1
Thanks for this example!

@civanch
Copy link
Contributor

civanch commented May 3, 2020

+1

@chayanit
Copy link

chayanit commented May 4, 2020

+1

@silviodonato
Copy link
Contributor

+operations

@kpedro88
Copy link
Contributor

kpedro88 commented May 4, 2020

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bc3645b into cms-sw:master May 4, 2020
@fwyzard
Copy link
Contributor Author

fwyzard commented May 4, 2020

In the meantime, following some suggestions from @missirol, I've prepared a configuration that adds PF rechits, PF clusters, and HLT-like PF superclusters.

I'm using an HLT-like configuration because the Offline configuration requires the primary vertices, and thus full tracking, etc., which is not really "ECAL-only" any more.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

See #29635.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants