small cleanup of CorrectedECALPFClusterProducer::fillDescriptions

[missirol]

PR description:

It seems that a couple of parameters specified in the fillDescriptions method of CorrectedECALPFClusterProducer are not really being used by the producer.

The two parameters are algoName and verticesLabel, and they are currently part of a PSet used to configure an instance of PFClusterEMEnergyCorrector.

As far as I can see, the primary vertices were used in previous versions of PFClusterEMEnergyCorrector (they were introduced in #7558), but then were later removed when the BDT training was updated (in #8872, which was a follow-up of #8818).

For the algoName parameter, in my understanding this was needed when PFClusterEMEnergyCorrector was inheriting from PFClusterEnergyCorrectorBase, but that is not the case anymore (since #7558).

The only change in Reconstruction_hiPF_cff is the removal of one line, which was modifying the value of one of these (unused) parameters.

No changes are expected.

PR validation:

Passed tests with runTheMatrix.py -l limited -i all.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29658/15058

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): [HBHE] Always use 8 pulses in MAHI without 1-pulse to 8-pulse switch for Run3 and beyond #29617

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

HLTrigger/Configuration
RecoHI/Configuration
RecoParticleFlow/PFClusterProducer

@perrotta, @cmsbuild, @fwyzard, @Martin-Grunewald, @slava77 can you please review it and eventually sign? Thanks.
@echapon, @mmarionncern, @makortel, @felicepantaleo, @riga, @kurtejung, @MiheeJo, @jazzitup, @lgray, @Martin-Grunewald, @yenjie, @clelange, @lecriste, @hatakeyamak, @mandrenguyen, @yetkinyilmaz, @rovere, @dgulhan, @seemasharmafnal, @cbernet this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6026/console Started: 2020/05/05 15:33

[cmsbuild]

+1
Tested at: e2ff927
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d47a9/6026/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Clean up BuildFiles under HLTriggerOffline/ #29637 @fwyzard: Clean up BuildFiles under HLTriggerOffline/
• Added particle flow candidates to particle flow validation #29628 @chosila: Added particle flow candidates to particle flow validation

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d47a9/6026/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d47a9/6026/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d47a9/6026/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696239
• DQMHistoTests: Total failures: 37
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2695883
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[Martin-Grunewald]

+1

[perrotta]

please test
(in order to clean up the comparison)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6151/console Started: 2020/05/07 12:38

[cmsbuild]

+1
Tested at: e2ff927
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d47a9/6151/summary.html
CMSSW: CMSSW_11_1_X_2020-05-06-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d47a9/6151/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697527
• DQMHistoTests: Total failures: 45
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697163
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[perrotta]

+1

• Technical: indeed the two parameters seems not to be used anywhere
• Jenkins tests pass and show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1