Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up BuildFiles under DQM/ #29666

Merged
merged 1 commit into from May 6, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 5, 2020

Clean up BuildFile.xml filea with xmllint --format.

Clean up BuildFile.xml filea with `xmllint --format`.
@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29666/15066

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6033/console Started: 2020/05/05 16:20

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

DQM/BeamMonitor
DQM/CSCMonitorModule
DQM/CTPPS
DQM/CastorMonitor
DQM/DTMonitorClient
DQM/DTMonitorModule
DQM/DataScouting
DQM/EcalCommon
DQM/EcalMonitorClient
DQM/EcalMonitorDbModule
DQM/EcalMonitorTasks
DQM/EcalPreshowerMonitorClient
DQM/EcalPreshowerMonitorModule
DQM/GEM
DQM/HLTEvF
DQM/HLXMonitor
DQM/HcalCommon
DQM/HcalTasks
DQM/Integration
DQM/L1TMonitor
DQM/L1TMonitorClient
DQM/MuonMonitor
DQM/Physics
DQM/PhysicsObjectsMonitoring
DQM/PixelLumi
DQM/RCTMonitor
DQM/RPCMonitorClient
DQM/RPCMonitorDigi
DQM/SiPixelCommon
DQM/SiPixelMonitorClient
DQM/SiPixelMonitorCluster
DQM/SiPixelMonitorDigi
DQM/SiPixelMonitorRawData
DQM/SiPixelMonitorRecHit
DQM/SiPixelMonitorTrack
DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Summary
DQM/SiPixelPhase1Track
DQM/SiStripCommissioningAnalysis
DQM/SiStripCommissioningClients
DQM/SiStripCommissioningDbClients
DQM/SiStripCommissioningSources
DQM/SiStripCommissioningSummary
DQM/SiStripCommon
DQM/SiStripMonitorClient
DQM/SiStripMonitorCluster
DQM/SiStripMonitorDigi
DQM/SiStripMonitorHardware
DQM/SiStripMonitorPedestals
DQM/SiStripMonitorSummary
DQM/SiStripMonitorTrack
DQM/SiTrackerPhase2
DQM/TrackerCommon
DQM/TrackerMonitorTrack
DQM/TrackingMonitor
DQM/TrackingMonitorClient
DQM/TrackingMonitorSource
DQM/TrigXMonitor
DQM/TrigXMonitorClient

@Martin-Grunewald, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @fwyzard can you please review it and eventually sign? Thanks.
@acimmino, @erikbutz, @rappoccio, @barvic, @batinkov, @hdelanno, @battibass, @makortel, @abdoulline, @forthommel, @jan-kaspar, @mtosi, @argiro, @missirol, @fioriNTU, @jandrea, @ptcox, @idebruyn, @venturia, @threus, @DryRun this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+1
Tested at: 925eaa7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d2f42/6033/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d2f42/6033/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d2f42/6033/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d2f42/6033/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695918
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented May 6, 2020

+1
Changes due to #29628

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 6671c0f into cms-sw:master May 6, 2020
@fwyzard fwyzard deleted the branch_lintBuildFile_DQM branch May 8, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants