Clean up BuildFiles under FWCore/ #29674

fwyzard · 2020-05-05T12:47:54Z

Clean up BuildFile.xml filea with xmllint --format.

fwyzard · 2020-05-05T12:47:56Z

@cmsbuild, please test

cmsbuild · 2020-05-05T12:48:43Z

The code-checks are being triggered in jenkins.

Clean up BuildFile.xml filea with `xmllint --format`.

fwyzard · 2020-05-05T13:00:22Z

@cmsbuild, please test

cmsbuild · 2020-05-05T13:00:34Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-05T13:26:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29674/15074

This PR adds an extra 80KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/test/BuildFile.xml modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553

cmsbuild · 2020-05-05T13:27:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6041/console Started: 2020/05/05 17:28

cmsbuild · 2020-05-05T13:27:21Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

FWCore/Catalog
FWCore/Common
FWCore/Concurrency
FWCore/FWLite
FWCore/Framework
FWCore/Integration
FWCore/MessageLogger
FWCore/MessageService
FWCore/Modules
FWCore/ParameterSet
FWCore/ParameterSetReader
FWCore/PluginManager
FWCore/PrescaleService
FWCore/PyDevParameterSet
FWCore/PythonFramework
FWCore/PythonParameterSet
FWCore/ROOTTests
FWCore/Reflection
FWCore/SOA
FWCore/ServiceRegistry
FWCore/Services
FWCore/SharedMemory
FWCore/Skeletons
FWCore/Sources
FWCore/TFWLiteSelector
FWCore/TFWLiteSelectorTest
FWCore/TestProcessor
FWCore/Utilities
FWCore/Version

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-05-05T20:00:42Z

-1

Tested at: 9bd0246

CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Clean up BuildFiles under HLTriggerOffline/ #29637 @fwyzard: Clean up BuildFiles under HLTriggerOffline/
Added particle flow candidates to particle flow validation #29628 @chosila: Added particle flow candidates to particle flow validation

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreServicesDriver had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Clean up BuildFiles under HLTriggerOffline/ #29637 @fwyzard: Clean up BuildFiles under HLTriggerOffline/
Added particle flow candidates to particle flow validation #29628 @chosila: Added particle flow candidates to particle flow validation

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/git-merge-result

cmsbuild · 2020-05-05T20:00:44Z

Comparison job queued.

cmsbuild · 2020-05-06T04:14:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f068f/6041/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696239
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2695919
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
Checked 147 log files, 16 edm output root files, 34 DQM output files

silviodonato · 2020-05-06T13:01:34Z

FWCore/Skeletons/scripts/mkTemplates/EDProducer/BuildFile.xml

@@ -4,5 +4,5 @@
 @example_myparticle <use name="PhysicsTools/UtilAlgos"/>
 @example_myparticle <use name="DataFormats/MuonReco"/>
 @example_myparticle <use name="DataFormats/EgammaCandidates"/>
-@example_myparticle <use name "DataFormats/Candidate"/>


silviodonato · 2020-05-06T13:01:50Z

merge

makortel · 2020-05-06T13:40:13Z

+1

post-merge

cmsbuild · 2020-05-06T13:40:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing).

cmsbuild added this to the CMSSW_11_1_X milestone May 5, 2020

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels May 5, 2020

fwyzard added 2 commits May 5, 2020 14:59

Clean up BuildFiles under FWCore/

0988afe

Clean up BuildFile.xml filea with `xmllint --format`.

Fix missing '=' sign

9bd0246

fwyzard force-pushed the branch_lintBuildFile_FWCore branch from bdf955a to 9bd0246 Compare May 5, 2020 13:00

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2020

cmsbuild added tests-started and removed tests-pending labels May 5, 2020

cmsbuild added tests-rejected and removed tests-started labels May 5, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 6, 2020

silviodonato reviewed May 6, 2020

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels May 6, 2020

cmsbuild merged commit b16f2df into cms-sw:master May 6, 2020

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels May 6, 2020

cmsbuild mentioned this pull request May 6, 2020

Revert "PUPPI MET in RECO" #29748

Merged

fwyzard deleted the branch_lintBuildFile_FWCore branch May 8, 2020 09:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up BuildFiles under FWCore/ #29674

Clean up BuildFiles under FWCore/ #29674

fwyzard commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 •

edited

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 6, 2020

silviodonato May 6, 2020

silviodonato commented May 6, 2020

makortel commented May 6, 2020

cmsbuild commented May 6, 2020

Clean up BuildFiles under FWCore/ #29674

Clean up BuildFiles under FWCore/ #29674

Conversation

fwyzard commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

fwyzard commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020 • edited

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 5, 2020

cmsbuild commented May 6, 2020

silviodonato May 6, 2020

Choose a reason for hiding this comment

silviodonato commented May 6, 2020

makortel commented May 6, 2020

cmsbuild commented May 6, 2020

cmsbuild commented May 5, 2020 •

edited