Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up BuildFiles under L1Trigger/ #29685

Merged
merged 1 commit into from
May 6, 2020
Merged

Clean up BuildFiles under L1Trigger/ #29685

merged 1 commit into from
May 6, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 5, 2020

Clean up BuildFile.xml filea with xmllint --format.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 5, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29685/15087

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6054/console Started: 2020/05/05 17:44

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

L1Trigger/CSCCommonTrigger
L1Trigger/CSCTrackFinder
L1Trigger/CSCTriggerPrimitives
L1Trigger/DTBti
L1Trigger/DTSectorCollector
L1Trigger/DTTrackFinder
L1Trigger/DTTraco
L1Trigger/DTTrigger
L1Trigger/DTTriggerServerPhi
L1Trigger/DTTriggerServerTheta
L1Trigger/DTUtilities
L1Trigger/GlobalCaloTrigger
L1Trigger/GlobalMuonTrigger
L1Trigger/GlobalTrigger
L1Trigger/GlobalTriggerAnalyzer
L1Trigger/HardwareValidation
L1Trigger/L1ExtraFromDigis
L1Trigger/L1GctAnalyzer
L1Trigger/L1TCaloLayer1
L1Trigger/L1TCalorimeter
L1Trigger/L1TCommon
L1Trigger/L1TGEM
L1Trigger/L1TGlobal
L1Trigger/L1THGCal
L1Trigger/L1THGCalUtilities
L1Trigger/L1TMuon
L1Trigger/L1TMuonBarrel
L1Trigger/L1TMuonCPPF
L1Trigger/L1TMuonEndCap
L1Trigger/L1TMuonOverlap
L1Trigger/L1TNtuples
L1Trigger/L1TTwinMux
L1Trigger/RPCTechnicalTrigger
L1Trigger/RPCTrigger
L1Trigger/RegionalCaloTrigger
L1Trigger/Skimmer
L1Trigger/TextToDigi
L1Trigger/TrackTrigger
L1Trigger/TrackerDTC

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @battibass, @sviret, @lgray, @valuev, @ptcox, @jbsauvan, @thomreis, @dildick, @amarini this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

-1

Tested at: 3258bae

CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c84bfe/6054/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c84bfe/6054/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c84bfe/6054/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/L1Trigger/CSCTrackFinder/test/analysis/CSCMakePTLUT.cc 
In file included from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/FWCore/Concurrency/interface/SerialTaskQueueChain.h:27,
                 from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/FWCore/Framework/interface/SharedResourcesAcquirer.h:22,
                 from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/FWCore/Framework/interface/EDAnalyzer.h:8,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/L1Trigger/CSCTrackFinder/test/analysis/CSCMakePTLUT.cc:11:
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/FWCore/Concurrency/interface/SerialTaskQueue.h:59:10: fatal error: tbb/task.h: No such file or directory
 #include "tbb/task.h"
          ^~~~~~~~~~~~
compilation terminated.
In file included from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/FWCore/Concurrency/interface/SerialTaskQueueChain.h:27,
                 from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/FWCore/Framework/interface/SharedResourcesAcquirer.h:22,
  • Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'


>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/L1Trigger/CSCTrackFinder/test/analysis/CSCMakeSRLUT.cc 
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/L1Trigger/CSCTrackFinder/test/analysis/CSCMakeSRLUT.cc:10:
In file included from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/FWCore/Framework/interface/EDAnalyzer.h:8:
In file included from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/FWCore/Framework/interface/SharedResourcesAcquirer.h:22:
In file included from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/FWCore/Concurrency/interface/SerialTaskQueueChain.h:27:
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/FWCore/Concurrency/interface/SerialTaskQueue.h:59:10: fatal error: 'tbb/task.h' file not found
#include "tbb/task.h"
         ^~~~~~~~~~~~
1 error generated.
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/L1Trigger/CSCTrackFinder/test/analysis/CSCMakeSRLUT.cc:10:
In file included from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_X_2020-05-05-1100/src/FWCore/Framework/interface/EDAnalyzer.h:8:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c84bfe/6054/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c84bfe/6054/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@fwyzard fwyzard force-pushed the branch_lintBuildFile_L1Trigger branch from 3258bae to 04f82fd Compare May 5, 2020 17:07
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@fwyzard fwyzard force-pushed the branch_lintBuildFile_L1Trigger branch from e77ffb1 to b902cd4 Compare May 5, 2020 17:37
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@fwyzard fwyzard force-pushed the branch_lintBuildFile_L1Trigger branch from b902cd4 to e7e6984 Compare May 5, 2020 17:38
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@fwyzard
Clean up BuildFiles under L1Trigger/
de78a45 
Clean up BuildFile.xml filea with `xmllint --format`.
@fwyzard fwyzard force-pushed the branch_lintBuildFile_L1Trigger branch from e7e6984 to de78a45 Compare May 5, 2020 17:39
@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29685/15166

  • This PR adds an extra 60KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6119/console Started: 2020/05/05 22:58

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Pull request #29685 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

+1
Tested at: de78a45
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c84bfe/6119/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c84bfe/6119/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c84bfe/6119/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c84bfe/6119/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695919
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

silviodonato
silviodonato reviewed May 6, 2020
View reviewed changes
L1Trigger/CSCTrackFinder/test/BuildFile.xml
@@ -1,51 +1,51 @@
<use name="SimDataFormats/Track"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fwyzard

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformatted the comments to use the proper XML syntax, and sorted

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 79af066 into cms-sw:master May 6, 2020
@fwyzard fwyzard deleted the branch_lintBuildFile_L1Trigger branch May 8, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silviodonato silviodonato silviodonato left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available l1-pending orp-approved pending-signatures tests-approved upgrade-pending
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fwyzard @cmsbuild @silviodonato