Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM10] Fix compilation warnings for L1 packages #29772

Merged
merged 1 commit into from
May 11, 2020
+3 −3
Merged

[LLVM10] Fix compilation warnings for L1 packages #29772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion L1Trigger/L1TMuonOverlap/src/OMTFinputMaker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ OMTFinput OMTFinputMaker::processDT(const L1MuDTChambPhContainer *dtPhDigis,
if (!dtPhDigis)
return result;

for (const auto digiIt : *dtPhDigis->getContainer()) {
for (const auto &digiIt : *dtPhDigis->getContainer()) {
DTChamberId detid(digiIt.whNum(), digiIt.stNum(), digiIt.scNum() + 1);

///Check it the data fits into given processor input range
Expand Down
2 changes: 1 addition & 1 deletion L1TriggerConfig/L1TConfigProducers/src/L1TGlobalPrescalesVetosOnlineProd.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ std::unique_ptr<const L1TGlobalPrescalesVetos> L1TGlobalPrescalesVetosOnlineProd
<< "\nWarning: No default found in BX mask xml, used 1 (unmasked) as default" << std::endl;
}

for (const std::pair<std::string, std::set<Range_t, RangeComp_t>> &algo : non_default_bx_ranges) {
for (auto &algo : non_default_bx_ranges) {
const std::string &algoName = algo.first;
unsigned int algoBit = algoName2bit[algoName];
for (auto range : algo.second)
Expand Down
2 changes: 1 addition & 1 deletion SimCalorimetry/HcalTrigPrimAlgos/src/HcalTriggerPrimitiveAlgo.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ void HcalTriggerPrimitiveAlgo::addUpgradeFG(const HcalTrigTowerDetId& id,
}

void HcalTriggerPrimitiveAlgo::setPeakFinderAlgorithm(int algo) {
if (algo <= 0 && algo > 2)
if (algo <= 0 || algo > 2)
throw cms::Exception("ERROR: Only algo 1 & 2 are supported.") << std::endl;
peak_finder_algorithm_ = algo;
}
Expand Down