[LLVM10] Fix compilation warnings for L1 packages

[smuzaffar]

PR description:

• Fixed loop variable copy warning generated in CLANG IBs
• Fix condition which was always false.

PR validation:

Local build for both CLANG and normal IBs look good

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29772/15224

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimCalorimetry/HcalTrigPrimAlgos/src/HcalTriggerPrimitiveAlgo.cc modified in PR(s): Handle Depth 7-only Signal in HcalTriggerPrimitiveAlgo #29634

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

L1Trigger/L1TMuonOverlap
L1TriggerConfig/L1TConfigProducers
SimCalorimetry/HcalTrigPrimAlgos

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @abdoulline, @thomreis, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6173/console Started: 2020/05/08 12:25

[cmsbuild]

+1
Tested at: e7fc1d9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca7c2b/6173/summary.html
CMSSW: CMSSW_11_1_X_2020-05-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca7c2b/6173/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697527
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697189
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[silviodonato]

merge
FYI @rekovic