Apply code checks to the FWCore packages #29885

fwyzard · 2020-05-18T11:08:03Z

Apply clang-tidy automated code changes.
Apply clang-format automated code formatting.

Enabled checks: boost-use-to-string misc-uniqueptr-reset-release modernize-deprecated-headers modernize-make-shared modernize-use-bool-literals modernize-use-equals-delete modernize-use-nullptr modernize-use-override performance-unnecessary-copy-initialization readability-container-size-empty readability-redundant-string-cstr readability-static-definition-in-anonymous-namespace readability-uniqueptr-delete-release

cmsbuild · 2020-05-18T11:09:14Z

The code-checks are being triggered in jenkins.

fwyzard · 2020-05-18T11:11:41Z

@cmsbuild, please test

cmsbuild · 2020-05-18T11:31:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29885/15457

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/interface/Event.h modified in PR(s): Enable additional code checks (effect of #29858) #29863
- File FWCore/Framework/interface/LuminosityBlock.h modified in PR(s): Enable additional code checks (effect of #29858) #29863
- File FWCore/Framework/interface/Run.h modified in PR(s): Enable additional code checks (effect of #29858) #29863
- File FWCore/Framework/interface/es_impl/MayConsumeChooser.h modified in PR(s): Enable additional code checks (effect of #29858) #29863
- File FWCore/Framework/interface/global/implementors.h modified in PR(s): Enable additional code checks (effect of #29858) #29863
- File FWCore/Utilities/interface/ECGetterBase.h modified in PR(s): Apply code checks to the Utilities packages #29896
- File FWCore/Utilities/interface/ExtensionCord.h modified in PR(s): Apply code checks to the Utilities packages #29896
- File FWCore/Utilities/interface/OutletBase.h modified in PR(s): Apply code checks to the Utilities packages #29896
- File FWCore/Utilities/interface/SimpleOutlet.h modified in PR(s): Apply code checks to the Utilities packages #29896

cmsbuild · 2020-05-18T11:32:57Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6374/console Started: 2020/05/18 13:36

cmsbuild · 2020-05-18T11:33:03Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

FWCore/Framework
FWCore/SOA
FWCore/Utilities

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2020-05-18T13:10:55Z

Looks good to me. Wonder why these changes didn't happen before.

makortel · 2020-05-18T13:51:37Z

Wonder why these changes didn't happen before.

Me too.

smuzaffar · 2020-05-18T15:08:33Z

clang-tidy changes for header files are triggered via the source files (.cc, .cpp) files of the package. We had noticed that some header files (order of 100+) missed clang-tidy changes as they were only include via sources of other packages.

cmsbuild · 2020-05-18T15:16:31Z

-1

Tested at: 5ab70e2

CMSSW: CMSSW_11_1_X_2020-05-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

EMTF May 2020 emulator update #29767 @jiafulow: EMTF May 2020 emulator update
Explictly include root's TObjString header to fix the unit test for ROOT6 Ibs #29862 @cms-sw: Explictly include root's TObjString header to fix the unit test for ROOT6 Ibs
Clean BuildFiles in ALCA #29805 @guitargeek: Clean BuildFiles in ALCA

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c444e4/6374/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c444e4/6374/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c444e4/6374/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

EMTF May 2020 emulator update #29767 @jiafulow: EMTF May 2020 emulator update
Explictly include root's TObjString header to fix the unit test for ROOT6 Ibs #29862 @cms-sw: Explictly include root's TObjString header to fix the unit test for ROOT6 Ibs
Clean BuildFiles in ALCA #29805 @guitargeek: Clean BuildFiles in ALCA

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c444e4/6374/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c444e4/6374/git-merge-result

cmsbuild · 2020-05-18T15:16:33Z

Comparison job queued.

fwyzard · 2020-05-18T16:00:32Z

---> test testTauEmbeddingProducers had ERRORS

Unrelated ?

fwyzard · 2020-05-18T16:01:06Z

@cmsbuild, please test

cmsbuild · 2020-05-19T06:06:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6409/console Started: 2020/05/19 09:32

cmsbuild · 2020-05-19T10:50:14Z

-1

Tested at: 5ab70e2

CMSSW: CMSSW_11_1_X_2020-05-18-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c444e4/6409/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

cmsbuild · 2020-05-19T10:50:17Z

Comparison job queued.

cmsbuild · 2020-05-19T12:33:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c444e4/6409/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2694466
DQMHistoTests: Total failures: 48
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2694369
DQMHistoTests: Total skipped: 49
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 150 log files, 16 edm output root files, 35 DQM output files

silviodonato · 2020-05-19T12:47:34Z

The unit test failure should be fixed in CMSSW_11_1_X_2020-05-18-2300 (see #29899)

silviodonato · 2020-05-19T17:03:46Z

please test

cmsbuild · 2020-05-19T17:04:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6432/console Started: 2020/05/19 19:07

cmsbuild · 2020-05-19T20:28:41Z

+1
Tested at: 5ab70e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c444e4/6432/summary.html
CMSSW: CMSSW_11_1_X_2020-05-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-19T20:28:44Z

Comparison job queued.

cmsbuild · 2020-05-19T21:59:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c444e4/6432/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2694466
DQMHistoTests: Total failures: 48
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2694369
DQMHistoTests: Total skipped: 49
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 150 log files, 16 edm output root files, 35 DQM output files

fwyzard added 3 commits May 18, 2020 12:23

cmsbuild added this to the CMSSW_11_1_X milestone May 18, 2020

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels May 18, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 18, 2020

cmsbuild added tests-started and removed tests-pending labels May 18, 2020

cmsbuild added tests-rejected and removed tests-started labels May 18, 2020

cmsbuild added tests-pending and removed tests-rejected labels May 18, 2020

cmsbuild added comparison-pending tests-pending labels May 19, 2020

cmsbuild added tests-started and removed tests-pending labels May 19, 2020

cmsbuild added tests-rejected and removed tests-started labels May 19, 2020

cmsbuild added comparison-available and removed comparison-pending labels May 19, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels May 19, 2020

cmsbuild added tests-started and removed tests-pending labels May 19, 2020

cmsbuild added tests-approved and removed tests-started labels May 19, 2020

cmsbuild merged commit 3e87d86 into cms-sw:master May 19, 2020

fwyzard deleted the Apply_clang-format_FWCore branch May 19, 2020 20:40

cmsbuild added comparison-available and removed comparison-pending labels May 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply code checks to the FWCore packages #29885

Apply code checks to the FWCore packages #29885

fwyzard commented May 18, 2020

cmsbuild commented May 18, 2020

fwyzard commented May 18, 2020

cmsbuild commented May 18, 2020

cmsbuild commented May 18, 2020 •

edited

cmsbuild commented May 18, 2020

Dr15Jones commented May 18, 2020

makortel commented May 18, 2020

smuzaffar commented May 18, 2020

cmsbuild commented May 18, 2020

cmsbuild commented May 18, 2020

fwyzard commented May 18, 2020

fwyzard commented May 18, 2020

cmsbuild commented May 19, 2020 •

edited

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

silviodonato commented May 19, 2020

silviodonato commented May 19, 2020

cmsbuild commented May 19, 2020 •

edited

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

Apply code checks to the FWCore packages #29885

Apply code checks to the FWCore packages #29885

Conversation

fwyzard commented May 18, 2020

cmsbuild commented May 18, 2020

fwyzard commented May 18, 2020

cmsbuild commented May 18, 2020

cmsbuild commented May 18, 2020 • edited

cmsbuild commented May 18, 2020

Dr15Jones commented May 18, 2020

makortel commented May 18, 2020

smuzaffar commented May 18, 2020

cmsbuild commented May 18, 2020

cmsbuild commented May 18, 2020

fwyzard commented May 18, 2020

fwyzard commented May 18, 2020

cmsbuild commented May 19, 2020 • edited

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

silviodonato commented May 19, 2020

silviodonato commented May 19, 2020

cmsbuild commented May 19, 2020 • edited

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 19, 2020

cmsbuild commented May 18, 2020 •

edited

cmsbuild commented May 19, 2020 •

edited

cmsbuild commented May 19, 2020 •

edited