New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply code checks to the Utilities packages #29896
Conversation
Utilities/General: - prevent eliding away copies in the benchmark
Enabled checks: boost-use-to-string misc-uniqueptr-reset-release modernize-deprecated-headers modernize-make-shared modernize-use-bool-literals modernize-use-equals-delete modernize-use-nullptr modernize-use-override performance-unnecessary-copy-initialization readability-container-size-empty readability-redundant-string-cstr readability-static-definition-in-anonymous-namespace readability-uniqueptr-delete-release
Enabled checks: boost-use-to-string misc-uniqueptr-reset-release modernize-deprecated-headers modernize-make-shared modernize-use-bool-literals modernize-use-equals-delete modernize-use-nullptr modernize-use-override performance-unnecessary-copy-initialization readability-container-size-empty readability-redundant-string-cstr readability-static-definition-in-anonymous-namespace readability-uniqueptr-delete-release
@cmsbuild, please test |
The code-checks are being triggered in jenkins. |
please test |
merge |
@cmsbuild merge |
@cmsbuild code-checks |
abort |
code-checks |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29896/15524
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: FWCore/Utilities @makortel, @smuzaffar, @cmsbuild, @Dr15Jones, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
Apply
clang-tidy
automated code changes.Apply
clang-format
automated code formatting.