[RFC] Test clang-tidy --checks performance-inefficient-vector-operation #29930

fwyzard · 2020-05-21T08:48:22Z

See the description at https://clang.llvm.org/extra/clang-tidy/checks/performance-inefficient-vector-operation.html .

cmsbuild · 2020-05-21T08:48:50Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-21T09:03:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29930/15546

This PR adds an extra 472KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File .clang-tidy modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, Enable additional code checks #29858, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks performance-move-const-arg #29931, Apply missed clang-tidy checks #29932, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks performance-inefficient-algorithm #29929, [RFC] Test clang-tidy --checks performance-implicit-conversion-in-loop #29928, [RFC] Test clang-tidy --checks performance-for-range-copy #29927, [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File Alignment/OfflineValidation/bin/DMRtrends.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File CalibCalorimetry/HcalAlgos/src/HcalLogicalMapGenerator.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File CalibPPS/ESProducers/plugins/CTPPSRPAlignmentCorrectionsDataESSourceXML.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File CaloOnlineTools/EcalTools/plugins/EcalCosmicsHists.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File CondFormats/HcalObjects/src/HBHEDarkening.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks performance-move-const-arg #29931, Apply missed clang-tidy checks #29932, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks performance-inefficient-algorithm #29929, [RFC] Test clang-tidy --checks performance-implicit-conversion-in-loop #29928, [RFC] Test clang-tidy --checks performance-for-range-copy #29927, [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File CondFormats/SiPixelObjects/src/SiPixelPerformanceSummary.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File CondTools/Ecal/src/EcalSRPHandler.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File DQM/HcalCommon/src/DetectorQuantity.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File DQM/HcalCommon/src/TrigTowerQuantity.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File DQMOffline/CalibTracker/plugins/SiStripPopConFEDErrorsDQM.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File DQMOffline/L1Trigger/src/HistDefinition.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File DQMOffline/Trigger/plugins/FSQDiJetAve.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File DQMServices/Core/src/DQMStore.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-for-range-copy #29927, [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File DataFormats/PatCandidates/src/CovarianceParameterization.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File ElectroWeakAnalysis/ZMuMu/plugins/dimuonHLTFilterCheck.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File FastSimulation/CTPPSFastTrackingProducer/plugins/CTPPSFastTrackingProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File FastSimulation/CTPPSRecHitProducer/plugins/CTPPSRecHitProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File Fireworks/Core/src/FWDialogBuilder.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks performance-move-const-arg #29931, Apply missed clang-tidy checks #29932, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks performance-inefficient-algorithm #29929, [RFC] Test clang-tidy --checks performance-implicit-conversion-in-loop #29928, [RFC] Test clang-tidy --checks performance-for-range-copy #29927, [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File Fireworks/ParticleFlow/plugins/FWPFCandidateDetailView.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File Geometry/EcalMapping/src/ESElectronicsMapper.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File HLTriggerOffline/SUSYBSM/src/HltSusyExoPostProcessor.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File L1Trigger/GlobalCaloTrigger/src/L1GctJetFinderBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File L1Trigger/L1TCalorimeter/interface/CaloParamsHelper.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File L1Trigger/L1TGEM/src/ME0Motherboard.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File L1Trigger/L1THGCal/src/backend/HGCalClusteringImpl.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File L1TriggerConfig/L1TConfigProducers/src/CaloParamsHelperO2O.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File MuonAnalysis/MomentumScaleCalibration/plugins/MuScleFit.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File PhysicsTools/Heppy/src/EGammaMvaEleEstimatorFWLite.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File PhysicsTools/Heppy/src/ReclusterJets.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File PhysicsTools/JetMCAlgos/plugins/CandOneToOneDeltaRMatcher.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoEcal/EgammaClusterAlgos/src/EndcapPiZeroDiscriminatorAlgo.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File RecoEcal/EgammaClusterAlgos/src/HybridClusterAlgo.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoEgamma/ElectronIdentification/src/ElectronMVAEstimatorRun2.cc modified in PR(s): Move EffectiveAreas and ThreadSafeFunctor classes out of EgammaTools #29832
- File RecoEgamma/PhotonIdentification/plugins/PhotonMVAEstimator.cc modified in PR(s): Move EffectiveAreas and ThreadSafeFunctor classes out of EgammaTools #29832
- File RecoJets/JetAlgorithms/src/FixedGridEnergyDensity.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoTauTag/RecoTau/src/PFTauPrimaryVertexProducerBase.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File RecoTauTag/RecoTau/src/RecoTauCommonUtilities.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File SimCalorimetry/HcalTrigPrimAlgos/src/HcalTriggerPrimitiveAlgo.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File SimG4CMS/ShowerLibraryProducer/plugins/HcalForwardLibWriter.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926
- File SimG4Core/Geometry/src/SensitiveDetectorCatalog.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File SimTracker/TrackAssociation/plugins/TrackTimeValueMapProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-for-range-copy #29927
- File TopQuarkAnalysis/TopKinFitter/plugins/TtFullLepKinSolutionProducer.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-05-21T09:04:13Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

.clang-tidy
Alignment/OfflineValidation
Alignment/TrackerAlignment
CalibCalorimetry/HcalAlgos
CalibPPS/ESProducers
CalibTracker/SiStripAPVAnalysis
CaloOnlineTools/EcalTools
CondFormats/HcalObjects
CondFormats/SiPixelObjects
CondTools/Ecal
DQM/HcalCommon
DQMOffline/CalibTracker
DQMOffline/L1Trigger
DQMOffline/Trigger
DQMServices/Core
DataFormats/L1Trigger
DataFormats/PatCandidates
ElectroWeakAnalysis/ZMuMu
FastSimulation/CTPPSFastTrackingProducer
FastSimulation/CTPPSRecHitProducer
Fireworks/Core
Fireworks/ParticleFlow
Geometry/EcalMapping
Geometry/HGCalGeometry
HLTriggerOffline/SUSYBSM
L1Trigger/GlobalCaloTrigger
L1Trigger/L1TCalorimeter
L1Trigger/L1TGEM
L1Trigger/L1THGCal
L1TriggerConfig/L1TConfigProducers
L1TriggerConfig/RPCTriggerConfig
MuonAnalysis/MomentumScaleCalibration
PhysicsTools/Heppy
PhysicsTools/JetMCAlgos
RecoEcal/EgammaClusterAlgos
RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification
RecoHI/HiJetAlgos
RecoJets/JetAlgorithms
RecoLocalMuon/DTSegment
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFProducer
RecoTauTag/RecoTau
RecoTracker/TkDetLayers
SimCalorimetry/HcalTrigPrimAlgos
SimG4CMS/ShowerLibraryProducer
SimG4Core/Geometry
SimTracker/SiStripDigitizer
SimTracker/TrackAssociation
TopQuarkAnalysis/TopKinFitter
Validation/EcalDigis

@andrius-k, @lveldere, @sbein, @schneiml, @ianna, @kpedro88, @rekovic, @fioriNTU, @tlampen, @pohsun, @santocch, @perrotta, @civanch, @makortel, @cmsbuild, @smuzaffar, @Dr15Jones, @cvuosalo, @ssekmen, @mdhildreth, @jfernan2, @tocheng, @slava77, @ggovi, @benkrikler, @kmaeshima, @christopheralanwest, @alja can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @gouskos, @yslai, @felicepantaleo, @jainshilpi, @schoef, @robervalwalsh, @emilbols, @missirol, @argiro, @Martin-Grunewald, @Fedespring, @thomreis, @tlampen, @yenjie, @ahinzmann, @lgray, @abbiendi, @varuns23, @slomeo, @sobhatta, @mmarionncern, @smoortga, @alja, @makortel, @mtosi, @peruzzim, @mandrenguyen, @cericeci, @jhgoh, @dgulhan, @jdolen, @prolay, @JyothsnaKomaragiri, @ebrondol, @seemasharmafnal, @cbernet, @ferencek, @rociovilar, @pieterdavid, @forthommel, @yetkinyilmaz, @Sam-Harper, @barvic, @DryRun, @afiqaize, @GiacomoSguazzoni, @tocheng, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @rovere, @threus, @hatakeyamak, @mschrode, @mmusich, @abdoulline, @fabiocos, @clelange, @kreczko, @HuguesBrun, @adewit, @rchatter, @trocino, @riga, @battibass, @gbenelli, @jazzitup, @calderona, @mverzett, @dkotlins, @lecriste, @kurtejung, @gpetruc, @matt-komm, @mariadalfonso, @amarini, @andrzejnovak, @folguera, @jbsauvan this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

pohsun · 2020-05-23T04:19:57Z

+1

santocch · 2020-05-23T07:08:31Z

+1

civanch · 2020-05-26T07:35:58Z

+1

jfernan2 · 2020-05-27T10:23:15Z

+1

ianna

IMHO, this is a good exercise that clearly indicates potential for code improvements.

BTW, DQM copies lots of strings. Perhaps, using string_views would help with performance?

ianna · 2020-05-28T14:33:43Z

FastSimulation/CTPPSFastTrackingProducer/plugins/CTPPSFastTrackingProducer.cc

@@ -97,6 +97,8 @@ CTPPSFastTrackingProducer::CTPPSFastTrackingProducer(const edm::ParameterSet& iC

  //Timing Detector Description
  std::vector<double> vToFCellWidth;
+  vToFCellWidth.reserve(8);


a one-line would do:

// Declaring new vector and copying // element of old vector // constructor method, Deep copy std::vector<double> vToFCellWidth(fToFCellWidth);

ianna · 2020-05-28T14:34:06Z

FastSimulation/CTPPSFastTrackingProducer/plugins/CTPPSFastTrackingProducer.cc

@@ -351,6 +353,8 @@ void CTPPSFastTrackingProducer::FastReco(int Direction, H_RecRPObject* station)
  double pos_tof = fToFInsertion * fBeamXRMS_ToF + fToFXOffset;
  int cellId = 0;
  std::vector<double> vToFCellWidth;
+  vToFCellWidth.reserve(8);


same here

std::vector<double> vToFCellWidth(fToFCellWidth);

ianna · 2020-05-28T14:34:16Z

FastSimulation/CTPPSRecHitProducer/plugins/CTPPSRecHitProducer.cc

@@ -222,6 +222,8 @@ void CTPPSRecHitProducer::produce(edm::Event& iEvent, const edm::EventSetup& iSe
      double pos_tof = fToFInsertion * fBeamXRMS_ToF + fToFXOffset;

      std::vector<double> vToFCellWidth;
+      vToFCellWidth.reserve(8);


same here

std::vector<double> vToFCellWidth(fToFCellWidth);

ianna · 2020-05-28T14:37:16Z

L1Trigger/L1TGEM/src/ME0Motherboard.cc

@@ -30,6 +30,8 @@ std::vector<ME0TriggerDigi> ME0Motherboard::readoutTriggers() {
  std::vector<ME0TriggerDigi> tmpV;

  std::vector<ME0TriggerDigi> all_trigs = getTriggers();
+  tmpV.reserve(all_trigs.size());


same here

std::vector<ME0TriggerDigi> tmpV(all_trigs);

ianna · 2020-05-28T14:50:02Z

PhysicsTools/JetMCAlgos/plugins/CandOneToOneDeltaRMatcher.cc

@@ -214,8 +214,12 @@ vector<int> CandOneToOneDeltaRMatcher::AlgoBruteForce(int nMin, int nMax) {
  float totalDeltaR = 0;
  float BestTotalDeltaR = 1000;

+  ca.reserve(nMax);


alternatively:

std::vector<int> ca(nMax); std::iota(ca.begin(), ca.end(), 0);

ianna · 2020-05-28T15:25:39Z

RecoHI/HiJetAlgos/src/HiGenCleaner.cc

@@ -94,6 +94,8 @@ void HiGenCleaner<T2>::produce(edm::StreamID, edm::Event& iEvent, const edm::Eve
  int jetsize = genjets->size();

  vector<int> selection;
+  selection.reserve(jetsize);


vector<int> selection(jetsize, -1);

ianna · 2020-05-28T15:26:48Z

RecoEgamma/EgammaTools/plugins/CalibratedPhotonProducers.cc

@@ -106,6 +106,8 @@ void CalibratedPhotonProducerT<T>::fillDescriptions(edm::ConfigurationDescriptio
  desc.add<bool>("produceCalibratedObjs", true);
  desc.add<bool>("semiDeterministic", true);
  std::vector<std::string> valMapsProduced;


string_view?

ianna · 2020-05-28T15:27:11Z

RecoEgamma/EgammaTools/plugins/CalibratedElectronProducers.cc

@@ -116,6 +116,8 @@ void CalibratedElectronProducerT<T>::fillDescriptions(edm::ConfigurationDescript
  desc.add<bool>("produceCalibratedObjs", true);
  desc.add<bool>("semiDeterministic", true);
  std::vector<std::string> valMapsProduced;


string_view?

ianna · 2020-05-28T15:27:55Z

RecoEcal/EgammaClusterAlgos/src/HybridClusterAlgo.cc

@@ -320,6 +320,8 @@ void HybridClusterAlgo::mainSearch(const EcalRecHitCollection* hits, const CaloS

    std::vector<int> OwnerShip;
    std::vector<double> LumpEnergy;
+    OwnerShip.reserve(int(dominoEnergy.size()));


std::vector<int> OwnerShip(int(dominoEnergy.size()), -1);

ianna · 2020-05-28T15:29:18Z

RecoLocalMuon/DTSegment/src/DTLinearFit.cc

@@ -279,6 +279,8 @@ void DTLinearFit::fit4Var(const vector<float>& xfit,
  int nppar3 = 0;
  int nppar4 = 0;

+  sigy.reserve(nptfit);


vector<float> sigy(nptfit, sigma);

slava77 · 2020-06-10T14:59:44Z

+1
sort of

the newline above the reserve would be much better as already mentioned in [RFC] Test clang-tidy --checks performance-inefficient-vector-operation #29930 (comment)

(also to take this off our review list)

mrodozov · 2020-06-30T16:54:03Z

note
fix new line issue

mrodozov · 2020-07-01T07:47:32Z

take it in fix the issue later

Test clang-tidy --checks performance-inefficient-vector-operation

cad25d8

cmsbuild added this to the CMSSW_11_1_X milestone May 21, 2020

fwyzard mentioned this pull request May 21, 2020

Enable additional code checks #29858

Closed

cmsbuild mentioned this pull request May 21, 2020

Apply missed clang-tidy checks #29932

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels May 21, 2020

smuzaffar modified the milestones: CMSSW_11_1_X, CMSSW_11_2_X May 22, 2020

cmsbuild added alca-approved and removed alca-pending labels May 23, 2020

cmsbuild added analysis-approved and removed analysis-pending labels May 23, 2020

cmsbuild added fastsim-approved simulation-approved and removed fastsim-pending simulation-pending labels May 26, 2020

cmsbuild added dqm-approved and removed dqm-pending labels May 27, 2020

ianna reviewed May 28, 2020

View reviewed changes

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 10, 2020

cmsbuild mentioned this pull request Jun 13, 2020

Delete some orphaned BuildFiles #30228

Merged

cmsbuild mentioned this pull request Jun 25, 2020

Revision of tau quality cut configuration #30364

Merged

cmsbuild mentioned this pull request Jul 2, 2020

Remove boost binding in Fireworks #30502

Merged

mrodozov mentioned this pull request Jul 2, 2020

[TEST ONLY][Do not merge] New clang tidy checks #30508

Closed

This was referenced Jul 10, 2020

Clang tidy checks - fix clang warnings #30632

Merged

Clang tidy checks - add new checks to .clang-tidy #30665

Merged

fwyzard closed this Jul 14, 2020

fwyzard deleted the clang-tidy-performance-inefficient-vector-operation branch July 14, 2020 16:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] Test clang-tidy --checks performance-inefficient-vector-operation #29930

[RFC] Test clang-tidy --checks performance-inefficient-vector-operation #29930

fwyzard commented May 21, 2020

cmsbuild commented May 21, 2020

cmsbuild commented May 21, 2020

cmsbuild commented May 21, 2020

pohsun commented May 23, 2020

santocch commented May 23, 2020

civanch commented May 26, 2020

jfernan2 commented May 27, 2020

ianna left a comment

ianna May 28, 2020

ianna May 28, 2020

ianna May 28, 2020

ianna May 28, 2020

ianna May 28, 2020

ianna May 28, 2020

ianna May 28, 2020

ianna May 28, 2020

ianna May 28, 2020

ianna May 28, 2020

slava77 commented Jun 10, 2020

mrodozov commented Jun 30, 2020

mrodozov commented Jul 1, 2020

[RFC] Test clang-tidy --checks performance-inefficient-vector-operation #29930

[RFC] Test clang-tidy --checks performance-inefficient-vector-operation #29930

Conversation

fwyzard commented May 21, 2020

cmsbuild commented May 21, 2020

cmsbuild commented May 21, 2020

cmsbuild commented May 21, 2020

pohsun commented May 23, 2020

santocch commented May 23, 2020

civanch commented May 26, 2020

jfernan2 commented May 27, 2020

ianna left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slava77 commented Jun 10, 2020

mrodozov commented Jun 30, 2020

mrodozov commented Jul 1, 2020